Add ModelRetry handling to DataFusionToolset#63501
Merged
gopidesupavan merged 2 commits intoapache:mainfrom Mar 14, 2026
Merged
Add ModelRetry handling to DataFusionToolset#63501gopidesupavan merged 2 commits intoapache:mainfrom
gopidesupavan merged 2 commits intoapache:mainfrom
Conversation
github-project-automation
bot
moved this to Backlog
in AIP-99 Common Data Access Pattern + AI
gopidesupavan
moved this from Backlog
to In review
in AIP-99 Common Data Access Pattern + AI
gopidesupavan
force-pushed
the
add-model-retry-mechanism-to-datafusiontoolset
branch
from
83cbdc1 to
82847cf
Compare
kaxil
approved these changes
Mar 13, 2026
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
LGTM — nice addition to retry on common query errors. A few minor suggestions below.
providers/common/ai/src/airflow/providers/common/ai/toolsets/datafusion.py
Outdated
Show resolved
Hide resolved
providers/common/ai/tests/unit/common/ai/toolsets/test_datafusion.py
Outdated
Show resolved
Hide resolved
providers/common/ai/tests/unit/common/ai/toolsets/test_datafusion.py
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from In review
to Done
in AIP-99 Common Data Access Pattern + AI
gopidesupavan
deleted the
add-model-retry-mechanism-to-datafusiontoolset
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup: #63358
Add
ModelRetryhandling toDataFusionToolsetfor retryable query failures caused by missing columns or missing tables.detect retryable DataFusion query errors by inspecting
QueryExecutionExceptionmessages, QueryExecutionException is our own builtin exception wraps in DataFusionEngine class. DataFusion python bindings doesn't support any native exceptions, it uses rust . so we had to realy on the regex patter for now.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.