Skip to content

[AIRFLOW-5684] docker-compose-kubernetes still used#6353

Merged
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:remove-old-docker-compose
Oct 17, 2019
Merged

[AIRFLOW-5684] docker-compose-kubernetes still used#6353
potiuk merged 1 commit into
apache:masterfrom
PolideaInternal:remove-old-docker-compose

Conversation

@potiuk
Copy link
Copy Markdown
Member

@potiuk potiuk commented Oct 16, 2019

Make sure you have checked all steps below.

Jira

After transitioning to KinD for kubernetes testing, we no longer need the docker-compose-kubernetes.yaml. However it still looks for this docker-compose in the breeze command. This PR removes these unneeded commands.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk requested review from asf-ci and dimberman and removed request for asf-ci October 16, 2019 19:58
@robertlagrant
Copy link
Copy Markdown

image
@potiuk Erm.

@potiuk potiuk merged commit f8794d8 into apache:master Oct 17, 2019
potiuk added a commit that referenced this pull request Oct 20, 2019
potiuk added a commit that referenced this pull request Oct 29, 2019
potiuk added a commit that referenced this pull request Nov 12, 2019
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
kaxil pushed a commit that referenced this pull request Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants