feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts#63562
Open
bittoby wants to merge 5 commits intoapache:mainfrom
Open
feat: Improve Playwright test patterns in plugins.spec.ts and PluginsPage.ts#63562bittoby wants to merge 5 commits intoapache:mainfrom
bittoby wants to merge 5 commits intoapache:mainfrom
Conversation
Author
|
@choo121600 Could you please review this PR? |
potiuk
added
the
ready for maintainer review
Author
|
@haseebmalik18 Thanks for your feedback! |
Author
|
@choo121600 @haseebmalik18 Please review again |
bittoby
force-pushed
the
feat/e2e-improve-playwright-patterns-plugins
branch
from
be07461 to
5e0bf39
Compare
bittoby
requested review from
bbovenzi,
guan404ming,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
Author
|
@choo121600 Review again. I updated |
8 tasks
choo121600
reviewed
Mar 16, 2026
Member
choo121600
left a comment
choo121600
left a comment
There was a problem hiding this comment.
Overall looks good to me :)
Let's wait for CI to pass.
choo121600
reviewed
Mar 16, 2026
Comment on lines
+45
to
+47
| const count = await pluginsPage.rows.count(); | ||
|
|
||
| for (const name of pluginNames) { | ||
| expect(name.trim().length).toBeGreaterThan(0); | ||
| expect(count).toBeGreaterThan(0); |
Member
There was a problem hiding this comment.
Could this be improved using a web-first assertion pattern like this?
await expect(pluginsPage.rows).not.toHaveCount(0);
const count = await pluginsPage.rows.count();
…2e-improve-playwright-patterns-plugins
bittoby
force-pushed
the
feat/e2e-improve-playwright-patterns-plugins
branch
from
451dccb to
2a91d6a
Compare
Author
|
@choo121600 All tests passed! |
Author
|
@choo121600 could you also review this PR, too? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve Playwright test patterns in
plugins.spec.tsandPluginsPage.tsto align with Playwright Best Practices.This PR improves test patterns only. It does not change test coverage or behavior.
Changes in
PluginsPage.ts:page.waitForFunction()with DOM queries with locator-basedwaitFor()nameColumnandsourceColumnas typedLocatorproperties instead of methods returningstring[]Changes in
plugins.spec.ts:not.toHaveCount(),not.toBeEmpty(),toHaveCount())related: #63429
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-4-6) following the guidelines