Fix zip DAG import errors being cleared during bundle refresh#63617
Open
gopidesupavan wants to merge 5 commits intoapache:mainfrom
Open
Fix zip DAG import errors being cleared during bundle refresh#63617gopidesupavan wants to merge 5 commits intoapache:mainfrom
gopidesupavan wants to merge 5 commits intoapache:mainfrom
Conversation
7d97abc to
2e5c599
Compare
2e5c599 to
da3c8e7
Compare
kaxil
reviewed
Mar 16, 2026
0391f4a to
18650fd
Compare
0d6f22d to
e977337
Compare
kaxil
reviewed
Mar 18, 2026
Member
kaxil
left a comment
There was a problem hiding this comment.
Minor note (not in diff): test_deactivate_deleted_dags_return_value still passes list literals (["test_dag1.py"]) to DagModel.deactivate_deleted_dags(rel_filelocs=...), but the type hint was changed to set[str]. Works at runtime, but a type checker would flag it.
e977337 to
1d9c664
Compare
Member
Author
yeah make sense my bad updated it now :) |
1d9c664 to
a694c0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle refresh cleanup was treating ZIP archives as if only the outer archive path existed. Import errors for DAGs inside a ZIP are stored with inner paths such as test_zip.zip/broken_dag.py, but the observed file set only contained test_zip.zip. As a result, clear_orphaned_import_errors() could incorrectly delete still-valid import errors for broken DAGs inside ZIP archives.
Was generative AI tooling used to co-author this PR?
Yes used for tests using copilot
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.