Skip to content

[AIRFLOW-5696] GoogleCloudStorageToSFTPOperator#6366

Merged
mik-laj merged 3 commits intoapache:masterfrom
PolideaInternal:gcs-to-sftp
Oct 22, 2019
Merged

[AIRFLOW-5696] GoogleCloudStorageToSFTPOperator#6366
mik-laj merged 3 commits intoapache:masterfrom
PolideaInternal:gcs-to-sftp

Conversation

@TobKed
Copy link
Contributor

@TobKed TobKed commented Oct 18, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5696
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 18, 2019
@codecov-io
Copy link

codecov-io commented Oct 21, 2019

Codecov Report

Merging #6366 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6366      +/-   ##
==========================================
- Coverage   80.49%   80.24%   -0.25%     
==========================================
  Files         616      618       +2     
  Lines       35822    35927     +105     
==========================================
- Hits        28834    28829       -5     
- Misses       6988     7098     +110
Impacted Files Coverage Δ
airflow/operators/gcs_to_sftp.py 100% <100%> (ø)
airflow/example_dags/example_gcs_to_sftp.py 100% <100%> (ø)
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/gcp/hooks/base.py 96.95% <0%> (-0.26%) ⬇️
airflow/utils/dag_processing.py 58.4% <0%> (-0.17%) ⬇️
airflow/gcp/hooks/text_to_speech.py 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d3cc41...c0871e7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants