Support list indexing in nested template fields#63662
Open
Gautam-Bharadwaj wants to merge 5 commits intoapache:mainfrom
Open
Support list indexing in nested template fields#63662Gautam-Bharadwaj wants to merge 5 commits intoapache:mainfrom
Gautam-Bharadwaj wants to merge 5 commits intoapache:mainfrom
Conversation
Member
|
Sounds reasonable to me. Can you add a test for this? |
d957acb to
6d6e616
Compare
Contributor
Author
|
@uranusjr Thanks for the review! I've added unit tests for |
Contributor
Author
Contributor
Author
|
@uranusjr plz review this pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working with nested template fields, I noticed that
_get_nested_valuelogic only supports dictionary keys and object attributes. This is a limitation when users define sequences/lists in their operator's template fields. I've updated the logic to handle integer keys for list indexing (e.g.,list.0).Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.