Skip to content

[AIRFLOW-5698][part of AIRFLOW-5697] Organize Dataflow tests#6368

Merged
potiuk merged 2 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-5698
Oct 21, 2019
Merged

[AIRFLOW-5698][part of AIRFLOW-5697] Organize Dataflow tests#6368
potiuk merged 2 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-5698

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Oct 18, 2019

This PR is one of a series that aims to improve this integration
https://issues.apache.org/jira/browse/AIRFLOW-5697


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-5698] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 18, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b8c0263). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6368   +/-   ##
=========================================
  Coverage          ?   80.09%           
=========================================
  Files             ?      616           
  Lines             ?    35804           
  Branches          ?        0           
=========================================
  Hits              ?    28677           
  Misses            ?     7127           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c0263...0216625. Read the comment docs.

@parameterized.expand([
("1dfjob@", ),
("dfjob@", ),
("df^jo", )
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tvalentyn are there any specific limitations on the first character of a dataflow job id ? (e.g. can't be _ or -. If so, I think that the hook might cast _ -> - and think it has fixed the name but in reality this may still be invalid. we should add a test case for something like this.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name must match the regular expression a-z?

I like the idea of trying to fix IDs. I enter it in the list of planned improvements. Thanks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed this question, dataflow job IDs start with a date, e.g. 2019-08-05

@potiuk potiuk merged commit ca77c01 into apache:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants