[AIRFLOW-5698][part of AIRFLOW-5697] Organize Dataflow tests#6368
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6368 +/- ##
=========================================
Coverage ? 80.09%
=========================================
Files ? 616
Lines ? 35804
Branches ? 0
=========================================
Hits ? 28677
Misses ? 7127
Partials ? 0Continue to review full report at Codecov.
|
| @parameterized.expand([ | ||
| ("1dfjob@", ), | ||
| ("dfjob@", ), | ||
| ("df^jo", ) |
There was a problem hiding this comment.
@tvalentyn are there any specific limitations on the first character of a dataflow job id ? (e.g. can't be _ or -. If so, I think that the hook might cast _ -> - and think it has fixed the name but in reality this may still be invalid. we should add a test case for something like this.
There was a problem hiding this comment.
The name must match the regular expression a-z?
I like the idea of trying to fix IDs. I enter it in the list of planned improvements. Thanks.
There was a problem hiding this comment.
Missed this question, dataflow job IDs start with a date, e.g. 2019-08-05
This PR is one of a series that aims to improve this integration
https://issues.apache.org/jira/browse/AIRFLOW-5697
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation