Skip to content

Fix: Removed the stray 's' and added a unit test to lock the formatting.#63712

Merged
jscheffl merged 3 commits intoapache:mainfrom
Nandann018-ux:codex/fix-filesyntaxerror-str
Mar 18, 2026
Merged

Fix: Removed the stray 's' and added a unit test to lock the formatting.#63712
jscheffl merged 3 commits intoapache:mainfrom
Nandann018-ux:codex/fix-filesyntaxerror-str

Conversation

@Nandann018-ux
Copy link
Contributor

@Nandann018-ux Nandann018-ux commented Mar 16, 2026

This PR fixes a typo in FileSyntaxError.__str__ that caused user-facing error messages to show an incorrect line number prefix, and adds a unit test to lock the correct formatting. It also includes a newsfragment for the bugfix.

Was generative AI tooling used to co-author this PR?

Yes

Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
When adding dependency, check compliance with the ASF 3rd Party License Policy.

For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@potiuk
Copy link
Member

potiuk commented Mar 16, 2026

You have some unrelated changes - can you please rebase and remove of those?

@Nandann018-ux Nandann018-ux force-pushed the codex/fix-filesyntaxerror-str branch from 417f56a to b27efac Compare March 16, 2026 18:35
@Nandann018-ux
Copy link
Contributor Author

Thanks for the heads‑up! I’ve rewritten the PR branch to include only the FileSyntaxError fix + test + newsfragment, rebased on apache/main. All unrelated commits are removed now. Could you please take another look?

@kaxil kaxil removed their request for review March 16, 2026 23:19
@Nandann018-ux Nandann018-ux force-pushed the codex/fix-filesyntaxerror-str branch from 4110f71 to ac7769a Compare March 18, 2026 13:45
@Nandann018-ux
Copy link
Contributor Author

@jscheffl
Thanks for catching that , I’ve removed the newsfragment and updated the PR.

@jscheffl jscheffl merged commit b9faa65 into apache:main Mar 18, 2026
75 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 18, 2026

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

github-actions bot pushed a commit that referenced this pull request Mar 18, 2026
…the formatting. (#63712)

* Fix FileSyntaxError string formatting

* Add newsfragment for FileSyntaxError fix

* Remove newsfragment per review
(cherry picked from commit b9faa65)

Co-authored-by: Nandan <samarthachar18@gmail.com>
@github-actions
Copy link

Backport successfully created: v3-1-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-1-test PR Link

@eladkal eladkal added this to the Airflow 3.1.9 milestone Mar 19, 2026
eladkal pushed a commit that referenced this pull request Mar 19, 2026
…the formatting. (#63712) (#63905)

* Fix FileSyntaxError string formatting

* Add newsfragment for FileSyntaxError fix

* Remove newsfragment per review
(cherry picked from commit b9faa65)

Co-authored-by: Nandan <samarthachar18@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:CLI area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants