Add test coverage for AzureBatchHook.wait_for_all_node_state#63765
Open
SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
Open
Add test coverage for AzureBatchHook.wait_for_all_node_state#63765SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
SameerMesiah97
force-pushed
the
AzureBatchHook-Missing-Tests
branch
2 times, most recently
from
2f30081 to
90042bd
Compare
Add tests verifying behavior when nodes are already in the target state, when node count is insufficient, when node states require retries, and when pool resize errors are present.
SameerMesiah97
force-pushed
the
AzureBatchHook-Missing-Tests
branch
from
90042bd to
76e86b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add unit tests for
AzureBatchHook.wait_for_all_node_state. The tests cover scenarios where nodes are immediately ready, where polling continues due to insufficient node count or node state, and where a pool resize error triggers an exception.Rationale
The test suite contained a
#TODOindicating missing coverage for this method. The polling logic inwait_for_all_node_statecontains multiple branches controlling loop termination and error handling that were not previously exercised by the test suite. Separate tests are used instead of parametrization to clearly represent the lifecycle and polling transitions of compute nodes.