Skip to content

[AIRFLOW-5711] Add fallback for connection's project ID in Dataflow integration#6383

Merged
potiuk merged 5 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-5711
Nov 8, 2019
Merged

[AIRFLOW-5711] Add fallback for connection's project ID in Dataflow integration#6383
potiuk merged 5 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-5711

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Oct 21, 2019

This PR is one of a series that aims to improve this integration
https://issues.apache.org/jira/browse/AIRFLOW-5697


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 21, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5711][part of AIRFLOW-5697][depends on AIRFLOW-5713, AIRFLOW-5712 ] Add fallback for connection's project ID in Dataflow integration [AIRFLOW-5711] Add fallback for connection's project ID in Dataflow integration Oct 22, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5711] Add fallback for connection's project ID in Dataflow integration [AIRFLOW-5711][WIP] Add fallback for connection's project ID in Dataflow integration Oct 22, 2019
@mik-laj mik-laj changed the title [AIRFLOW-5711][WIP] Add fallback for connection's project ID in Dataflow integration [AIRFLOW-5711] Add fallback for connection's project ID in Dataflow integration Oct 22, 2019
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6383 into master will increase coverage by 3.37%.
The diff coverage is 95.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6383      +/-   ##
==========================================
+ Coverage   80.59%   83.97%   +3.37%     
==========================================
  Files         626      627       +1     
  Lines       36243    36541     +298     
==========================================
+ Hits        29211    30684    +1473     
+ Misses       7032     5857    -1175
Impacted Files Coverage Δ
airflow/gcp/operators/dataflow.py 99.07% <75%> (ø) ⬆️
airflow/gcp/hooks/dataflow.py 92.24% <97.36%> (+1.08%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/models/dagbag.py 85.24% <0%> (-7.18%) ⬇️
airflow/example_dags/example_trigger_target_dag.py 90% <0%> (-2.31%) ⬇️
airflow/api/common/experimental/delete_dag.py 86.66% <0%> (-0.84%) ⬇️
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d2a0d...1d24daf. Read the comment docs.

Copy link
Copy Markdown
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Nice and simple

@potiuk potiuk merged commit bec38b9 into apache:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants