[AIRFLOW-5717] Add get_tree_map method to SFTPHook#6387
Merged
mik-laj merged 2 commits intoOct 26, 2019
Conversation
mik-laj
reviewed
Oct 23, 2019
mik-laj
reviewed
Oct 23, 2019
Member
There was a problem hiding this comment.
Can you create a variables from this callback. Now it's hard to read.
Contributor
Author
There was a problem hiding this comment.
Sure, I've refactored this part in little bit different way to avoid redundant code.
80a87fc to
06573da
Compare
06573da to
a12ead9
Compare
Codecov Report
@@ Coverage Diff @@
## master #6387 +/- ##
==========================================
- Coverage 80.59% 79.68% -0.92%
==========================================
Files 626 626
Lines 36243 36257 +14
==========================================
- Hits 29211 28891 -320
- Misses 7032 7366 +334
Continue to review full report at Codecov.
|
mik-laj
approved these changes
Oct 26, 2019
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation