Skip to content

[AIRFLOW-5717] Add get_tree_map method to SFTPHook#6387

Merged
mik-laj merged 2 commits into
apache:masterfrom
PolideaInternal:add-get-map-tree-sftp-hook
Oct 26, 2019
Merged

[AIRFLOW-5717] Add get_tree_map method to SFTPHook#6387
mik-laj merged 2 commits into
apache:masterfrom
PolideaInternal:add-get-map-tree-sftp-hook

Conversation

@TobKed
Copy link
Copy Markdown
Contributor

@TobKed TobKed commented Oct 22, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5717
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

Comment thread airflow/contrib/hooks/sftp_hook.py Outdated
Comment thread airflow/contrib/hooks/sftp_hook.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a variables from this callback. Now it's hard to read.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I've refactored this part in little bit different way to avoid redundant code.

@TobKed TobKed force-pushed the add-get-map-tree-sftp-hook branch 4 times, most recently from 80a87fc to 06573da Compare October 23, 2019 13:34
@TobKed TobKed force-pushed the add-get-map-tree-sftp-hook branch from 06573da to a12ead9 Compare October 23, 2019 17:08
@TobKed TobKed requested a review from mik-laj October 23, 2019 17:10
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6387 into master will decrease coverage by 0.91%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6387      +/-   ##
==========================================
- Coverage   80.59%   79.68%   -0.92%     
==========================================
  Files         626      626              
  Lines       36243    36257      +14     
==========================================
- Hits        29211    28891     -320     
- Misses       7032     7366     +334
Impacted Files Coverage Δ
airflow/contrib/hooks/sftp_hook.py 94.79% <100%> (+0.88%) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_operator.py 0% <0%> (-100%) ⬇️
airflow/operators/mysql_to_hive.py 0% <0%> (-100%) ⬇️
airflow/operators/generic_transfer.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
airflow/executors/celery_executor.py 41.04% <0%> (-35.08%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74d2a0d...a12ead9. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants