Skip to content

[AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook#6388

Closed
michalslowikowski00 wants to merge 0 commit into
apache:masterfrom
PolideaInternal:AIRFLOW-5669-Rename-GoogleCloudBaseHook-to-CloudBaseHook
Closed

[AIRFLOW-5669] Rename GoogleCloudBaseHook to CloudBaseHook#6388
michalslowikowski00 wants to merge 0 commit into
apache:masterfrom
PolideaInternal:AIRFLOW-5669-Rename-GoogleCloudBaseHook-to-CloudBaseHook

Conversation

@michalslowikowski00
Copy link
Copy Markdown
Contributor

Part of AIP-21

  • renamed GoogleCloudBaseHook to CloudBaseHook
  • added added to gcp_api_base_hook.py deprecation warning

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5569
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 23, 2019

This PR have conflicts. Can you do rebase?

@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5669-Rename-GoogleCloudBaseHook-to-CloudBaseHook branch 2 times, most recently from 16fa409 to 254e1e8 Compare October 24, 2019 10:03
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5dd1dbc). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6388   +/-   ##
=========================================
  Coverage          ?   83.96%           
=========================================
  Files             ?      627           
  Lines             ?    36530           
  Branches          ?        0           
=========================================
  Hits              ?    30673           
  Misses            ?     5857           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/gcp/hooks/cloud_build.py 100% <100%> (ø)
airflow/gcp/hooks/cloud_memorystore.py 73.83% <100%> (ø)
airflow/gcp/hooks/cloud_sql.py 70.23% <100%> (ø)
airflow/gcp/hooks/compute.py 86.86% <100%> (ø)
airflow/gcp/hooks/gcs.py 84.98% <100%> (ø)
airflow/gcp/hooks/tasks.py 92.17% <100%> (ø)
airflow/gcp/hooks/video_intelligence.py 89.47% <100%> (ø)
airflow/gcp/hooks/bigquery.py 70.18% <100%> (ø)
airflow/gcp/hooks/bigquery_dts.py 85.96% <100%> (ø)
airflow/gcp/hooks/dlp.py 98.69% <100%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dd1dbc...47087a3. Read the comment docs.

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 25, 2019
@michalslowikowski00
Copy link
Copy Markdown
Contributor Author

@mik-laj all conflicts are resolved.

@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5669-Rename-GoogleCloudBaseHook-to-CloudBaseHook branch 2 times, most recently from 40eddc7 to 47087a3 Compare October 26, 2019 12:41
@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5669-Rename-GoogleCloudBaseHook-to-CloudBaseHook branch from 47087a3 to 3fb9d49 Compare October 28, 2019 13:03
@michalslowikowski00 michalslowikowski00 deleted the AIRFLOW-5669-Rename-GoogleCloudBaseHook-to-CloudBaseHook branch October 28, 2019 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants