Skip to content

[AIRFLOW-5723] Simplify illegal arguments test#6394

Merged
mik-laj merged 1 commit into
apache:masterfrom
PolideaInternal:improve-core-test1
Oct 25, 2019
Merged

[AIRFLOW-5723] Simplify illegal arguments test#6394
mik-laj merged 1 commit into
apache:masterfrom
PolideaInternal:improve-core-test1

Conversation

@turbaszek
Copy link
Copy Markdown
Member

@turbaszek turbaszek commented Oct 23, 2019

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    This PR simplify a test, testing that operator reject illegal arguments.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@d5dc1e2). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6394   +/-   ##
=========================================
  Coverage          ?   80.04%           
=========================================
  Files             ?      626           
  Lines             ?    36217           
  Branches          ?        0           
=========================================
  Hits              ?    28989           
  Misses            ?     7228           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5dc1e2...af0fa4a. Read the comment docs.

@mik-laj mik-laj merged commit 3b0da2f into apache:master Oct 25, 2019
@turbaszek turbaszek deleted the improve-core-test1 branch December 4, 2019 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants