Skip to content

Fix mypy errors in kubernetes, fab, google, and amazon providers#63947

Merged
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-provider-mypy-errors
Mar 19, 2026
Merged

Fix mypy errors in kubernetes, fab, google, and amazon providers#63947
potiuk merged 1 commit intoapache:mainfrom
potiuk:fix-provider-mypy-errors

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Mar 19, 2026

Fix 5 pre-existing mypy errors across 4 provider files:

  • kubernetes_executor: handle None executor_config before calling .get()
  • fab_auth_manager: filter None values from Pool.pool query results
  • stackdriver_task_handler: provide fallback for None hostname
  • ecs_executor: handle nullable queue and executor_config in add_task call

Was generative AI tooling used to co-author this PR?
  • Yes — Claude Code (Claude Opus 4.6)

Generated-by: Claude Code (Claude Opus 4.6) following the guidelines

- kubernetes_executor: handle None executor_config before calling .get()
- fab_auth_manager: filter None values from Pool.pool query results
- stackdriver_task_handler: provide fallback for None hostname
- ecs_executor: handle None queue and executor_config in add_task call
@boring-cyborg boring-cyborg bot added area:logging area:providers provider:amazon AWS/Amazon - related issues provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:fab provider:google Google (including GCP) related issues labels Mar 19, 2026
@potiuk
Copy link
Member Author

potiuk commented Mar 19, 2026

Those currently fail on main

@potiuk
Copy link
Member Author

potiuk commented Mar 19, 2026

It's because of new attrs released.

@potiuk
Copy link
Member Author

potiuk commented Mar 19, 2026

Thie is also the reason for #63942 I added the commit there too.

@potiuk potiuk merged commit b7ef55a into apache:main Mar 19, 2026
82 of 84 checks passed
@potiuk potiuk deleted the fix-provider-mypy-errors branch March 19, 2026 18:58
fat-catTW pushed a commit to fat-catTW/airflow that referenced this pull request Mar 22, 2026
…che#63947)

- kubernetes_executor: handle None executor_config before calling .get()
- fab_auth_manager: filter None values from Pool.pool query results
- stackdriver_task_handler: provide fallback for None hostname
- ecs_executor: handle None queue and executor_config in add_task call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:logging area:providers provider:amazon AWS/Amazon - related issues provider:cncf-kubernetes Kubernetes (k8s) provider related issues provider:fab provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants