Skip to content

add application name as env var to driver and executor pods for SparkKubernetesOperator#64015

Merged
jscheffl merged 11 commits intoapache:mainfrom
Shrividya:add-spark-application-name
Mar 22, 2026
Merged

add application name as env var to driver and executor pods for SparkKubernetesOperator#64015
jscheffl merged 11 commits intoapache:mainfrom
Shrividya:add-spark-application-name

Conversation

@Shrividya
Copy link
Contributor

@Shrividya Shrividya commented Mar 20, 2026

  • added spark application name to both driver and executor components in template body
  • custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var.
  • tests added accordingly -changelog.rst updated.

Was generative AI tooling used to co-author this PR?
  • Yes

Generated-by: Claude(Anthropic) following the guidelines - used for review, debugging failing tests and suggesting fixes for test failures iteratively


  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

…KubernetesOperator

- added spark application name to both driver and executor components in template body
- custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var.
- tests added accordingly
-changelog.rst updated.
@Shrividya Shrividya requested a review from jscheffl March 20, 2026 19:57
@tardunge
Copy link

@Shrividya Thanks, this will keep the driver and executor pod names consistent with this env var. Thanks for your contribution.

@Shrividya Shrividya force-pushed the add-spark-application-name branch from 43d4ca8 to efdf49e Compare March 20, 2026 22:17
@potiuk potiuk closed this Mar 21, 2026
@potiuk potiuk reopened this Mar 21, 2026
…KubernetesOperator

- added spark application name to both driver and executor components in template body
- custom object launcher already had a value for the env under spec["item"]. The application name is added along with the k8_spec env var.
- tests added accordingly
-changelog.rst updated.
@Shrividya Shrividya force-pushed the add-spark-application-name branch from efdf49e to 449d3e1 Compare March 21, 2026 18:41
@jscheffl jscheffl marked this pull request as draft March 22, 2026 08:41
@jscheffl
Copy link
Contributor

@Shrividya This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Pre-commit / static checks: Failing: CI image checks / Static checks. Run prek run --from-ref main locally to find and fix issues. See Pre-commit / static checks docs.
  • Provider tests: Failing: provider distributions tests / Compat 2.11.1:P3.10:, provider distributions tests / Compat 3.0.6:P3.10:, provider distributions tests / Compat 3.1.8:P3.10:, Non-DB tests: providers / Non-DB-prov::3.10:amazon...google. Run provider tests with breeze run pytest <provider-test-path> -xvs. See Provider tests docs.
  • Kubernetes tests: Failing: Low dep tests: providers / All-prov:LowestDeps:14:3.10:cncf.kubernetes. See the K8s testing documentation. See Kubernetes tests docs.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.

@Shrividya Shrividya marked this pull request as ready for review March 22, 2026 21:11
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crossing fingers CI is green, then good to merge in my view.

@jscheffl jscheffl merged commit bf1e5fd into apache:main Mar 22, 2026
111 checks passed
@Shrividya Shrividya deleted the add-spark-application-name branch March 23, 2026 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SPARK_APPLICATION_NAME env variable to driver and executor pods when using SparkKubernetesOperator

4 participants