fix(ui): guard against null/undefined dates in Gantt chart to prevent RangeError#64031
Open
idrisakorede wants to merge 2 commits intoapache:mainfrom
Open
fix(ui): guard against null/undefined dates in Gantt chart to prevent RangeError#64031idrisakorede wants to merge 2 commits intoapache:mainfrom
idrisakorede wants to merge 2 commits intoapache:mainfrom
Conversation
Member
|
@idrisakorede This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
bbovenzi
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Grid View crash (
RangeError: Invalid time value) when viewing tasks in non-terminal states (scheduled, running) with "Show Gantt" enabled. This is a regression from 3.1.7 introduced by #61250.Root cause:
dayjs(value).toISOString()is called on null/undefined date values for tasks that haven't completed yet.Changes in
utils.ts:=== null→ falsy check (!value) to also catchundefined!tryInstance.end_datefallback so null end dates use current time instead of crashingNo test coverage or behavior changes beyond the null guard. Tasks with missing end dates now render a bar extending to "now" (consistent with running task behavior).
closes: #63954
Was generative AI tooling used to co-author this PR?