fix: handle NULL values in /dags/{dag_id}/tasks order_by parameter#64075
fix: handle NULL values in /dags/{dag_id}/tasks order_by parameter#64075Aliipou wants to merge 1 commit intoapache:mainfrom
/dags/{dag_id}/tasks order_by parameter#64075Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Thanks for the PR! I think changes should be on Pydantic model. Adding a validator is just for this cases and you can even manage time to execute like before after. There are different types of examples in our repo, could you please use that approach and add unit tests?
What I see in the issue is when wrong value passed the sorted won't work. That's why easier to do validations there
pierrejeambrun
left a comment
There was a problem hiding this comment.
Closing, duplicate of #63991, missing unit tests too
Closes #63927
Adds
nullslast()handling to the SQLAlchemyorder_byclause in the tasks listing endpoint to correctly handle NULL values and prevent incorrect sort ordering.