Improve Playwright test patterns in providers.spec.ts#64078
Improve Playwright test patterns in providers.spec.ts#64078hussain-s wants to merge 3 commits intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
| ); | ||
| public async waitForLoad(): Promise<void> { | ||
| await expect(this.table).toBeVisible({ timeout: 30_000 }); | ||
| await expect(this.rows.first()).toBeVisible({ timeout: 30_000 }); |
There was a problem hiding this comment.
Nit: The original waitForTableData() specifically checked for "tbody tr td a" links to distinguish real data from skeleton rows. In this line, the check would pass as soon as it identifies ,even before the real data loads.
There was a problem hiding this comment.
Good catch. I tightened waitForLoad() so it now waits for the first provider link to be visible, not just the first row shell. That keeps the readiness check tied to real table content while staying locator-based.
Summary
Improve Playwright test patterns in
providers.spec.tsandProvidersPage.tswithout changing test coverage or behavior.What changed
Validation
pnpm exec eslint tests/e2e/specs/providers.spec.ts tests/e2e/pages/ProvidersPage.tspnpm exec tsc --noEmit -p tsconfig.app.jsonTEST_USERNAME=admin TEST_PASSWORD=admin AIRFLOW_UI_BASE_URL=http://localhost:28080 pnpm exec playwright test tests/e2e/specs/providers.spec.ts --project=chromiumRelates to #63431