Skip to content

[AIRFLOW-5674][WIP] rename GoogleCloudKMSHook to CloudKmsHook#6408

Closed
michalslowikowski00 wants to merge 3 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-5674-rename-GoogleCloudKMSHook-to-CloudKmsHook
Closed

[AIRFLOW-5674][WIP] rename GoogleCloudKMSHook to CloudKmsHook#6408
michalslowikowski00 wants to merge 3 commits intoapache:masterfrom
PolideaInternal:AIRFLOW-5674-rename-GoogleCloudKMSHook-to-CloudKmsHook

Conversation

@michalslowikowski00
Copy link
Copy Markdown
Contributor

Part of AIP-21

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5674
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #6408 into master will decrease coverage by 0.56%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6408      +/-   ##
==========================================
- Coverage   80.61%   80.05%   -0.57%     
==========================================
  Files         626      626              
  Lines       36224    36228       +4     
==========================================
- Hits        29203    29002     -201     
- Misses       7021     7226     +205
Impacted Files Coverage Δ
airflow/contrib/hooks/gcp_kms_hook.py 100% <100%> (ø) ⬆️
airflow/gcp/hooks/kms.py 100% <100%> (ø) ⬆️
airflow/operators/postgres_operator.py 0% <0%> (-100%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/executors/sequential_executor.py 47.61% <0%> (-52.39%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/utils/log/colored_log.py 72.72% <0%> (-20.46%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 859e1cc...ba8189b. Read the comment docs.

Copy link
Copy Markdown
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use shortcuts, we should write them Capitalized e.g. GKE, GCS

https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit?ts=5bb72dfd#

We need to update our planned changes

Copy link
Copy Markdown
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we use shortcuts, we should write them Capitalized e.g. GKE, GCS

https://docs.google.com/document/d/1_rTdJSLCt0eyrAylmmgYc3yZr-_h51fVlnvMmWqhCkY/edit?ts=5bb72dfd#

We need to update our planned changes

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 25, 2019
@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 25, 2019

@michalslowikowski00
Copy link
Copy Markdown
Contributor Author

@mik-laj Should I change the name to CloudKMSHook?

@mik-laj mik-laj changed the title [AIRFLOW-5674] rename GoogleCloudKMSHook to CloudKmsHook [AIRFLOW-5674][WIP] rename GoogleCloudKMSHook to CloudKmsHook Oct 28, 2019
@mik-laj mik-laj added the AIP-21 label Oct 29, 2019
@michalslowikowski00 michalslowikowski00 deleted the AIRFLOW-5674-rename-GoogleCloudKMSHook-to-CloudKmsHook branch December 9, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants