Skip to content

[AIRFLOW-5677] Rename GCPSpeechToTextHook to CloudSpeechToTextHook#6410

Merged
mik-laj merged 3 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook
Nov 4, 2019
Merged

[AIRFLOW-5677] Rename GCPSpeechToTextHook to CloudSpeechToTextHook#6410
mik-laj merged 3 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook

Conversation

@michalslowikowski00
Copy link
Copy Markdown
Contributor

Part of AIP-21

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5677
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 24, 2019

Codecov Report

Merging #6410 into master will decrease coverage by 0.24%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6410      +/-   ##
=========================================
- Coverage   83.95%   83.7%   -0.25%     
=========================================
  Files         635     635              
  Lines       36674   36678       +4     
=========================================
- Hits        30788   30701      -87     
- Misses       5886    5977      +91
Impacted Files Coverage Δ
airflow/gcp/operators/speech_to_text.py 92.85% <100%> (ø) ⬆️
airflow/contrib/hooks/gcp_speech_to_text_hook.py 100% <100%> (ø) ⬆️
airflow/gcp/operators/translate_speech.py 86.36% <100%> (ø) ⬆️
airflow/gcp/hooks/speech_to_text.py 100% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/jobs/backfill_job.py 89.9% <0%> (-1.53%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb01616...0d1936c. Read the comment docs.

@mik-laj mik-laj added the provider:google Google (including GCP) related issues label Oct 25, 2019
@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 25, 2019

@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook branch from a132fc2 to 1153b1b Compare October 28, 2019 09:20
@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 28, 2019

Can you do a rebase?

@michalslowikowski00
Copy link
Copy Markdown
Contributor Author

@mik-laj Conflict has been resolved

@michalslowikowski00 michalslowikowski00 changed the title [AIRFLOW-5677] rename GCPSpeechToTextHook to CloudSpeechToTextHook [AIRFLOW-5677] Rename GCPSpeechToTextHook to CloudSpeechToTextHook Oct 29, 2019
Comment thread UPDATING.md Outdated
@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook branch from 264bd54 to 1153b1b Compare October 29, 2019 13:00
@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook branch from 1153b1b to 66fc0f2 Compare October 29, 2019 13:10
@mik-laj mik-laj added the AIP-21 label Oct 29, 2019
Comment thread airflow/contrib/hooks/gcp_speech_to_text_hook.py Outdated
Comment thread airflow/contrib/hooks/gcp_speech_to_text_hook.py Outdated
@michalslowikowski00 michalslowikowski00 force-pushed the AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook branch from 66fc0f2 to 0d1936c Compare November 4, 2019 09:14
@mik-laj mik-laj merged commit 4a90ba0 into apache:master Nov 4, 2019
@mik-laj mik-laj deleted the AIRFLOW-5677-rename-GCPSpeechToTextHook-to-CloudSpeechToTextHook branch November 4, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants