Add tests for execute_complete success and error handling in AirbyteTriggerSyncOperator#64119
Open
SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
Open
Add tests for execute_complete success and error handling in AirbyteTriggerSyncOperator#64119SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
SameerMesiah97 wants to merge 1 commit intoapache:mainfrom
Conversation
Covers behavior where execute_complete returns successfully on non-error events and raises on error events. AirflowException has been replaced with RuntimeError.
Contributor
Author
|
CI failure is unrelated to my changes. It was present in PR #64084, which only changes the spelling of a 'deferrable' in one of the log messages within the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds unit tests for
AirbyteTriggerSyncOperator.execute_complete. The tests cover scenarios where the operator completes successfully on non-error events and where an error event triggers an exception.Rationale
execute_completeis a key part of the deferrable execution flow but was not previously covered by the test suite. The method contains branching logic based on trigger event status that determines whether execution succeeds or fails.Notes
AirflowExceptiontoRuntimeErrorto align with agreed consensus and current implementation, as one of the tests asserts that an error is raised.