Closed
Conversation
rjgoyln
requested review from
bugraoz93,
hussein-awala,
jedcunningham and
jscheffl
as code owners
plaes
reviewed
Mar 24, 2026
potiuk
added
the
ready for maintainer review
rjgoyln
force-pushed
the
Include_key_names
branch
from
888870e to
04c954a
Compare
3 tasks
jscheffl
reviewed
Mar 28, 2026
Comment on lines
500
to
+502
| data: | ||
| # If secret names are provided, use those secrets | ||
| # These secrets must be created manually, eg: | ||
| # | ||
| # kind: Secret | ||
| # apiVersion: v1 | ||
| # metadata: | ||
| # name: custom-airflow-metadata-secret | ||
| # type: Opaque | ||
| # data: | ||
| # connection: base64_encoded_connection_string | ||
|
|
||
| # Must contain a 'connection' key (e.g., postgresql://user:pass@host:5432/db). | ||
| # Optional: 'kedaConnection'. Note: URL-encode special characters in passwords. |
Contributor
There was a problem hiding this comment.
I am not sure if and why your description is now better than the example before. The example before which you now are removing had an example. Yes it was not mentioning that the connection key is needed.
I'd favor keeping the example and marking the note that key(s) are needed.
jscheffl
reviewed
Mar 28, 2026
| # Must contain a 'connection' key. If not provided, it falls back to 'metadataSecretName'. | ||
| resultBackendSecretName: ~ | ||
|
|
||
| # Must contain a 'connection' key (e.g., redis://:pass@host:6379/0). |
Contributor
There was a problem hiding this comment.
...and also I'd not repeat it here but propose to add this to the note that the key is relevant for all options below.
Contributor
|
PR #64136 was merged which is redundant to this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing documentation for several secret name parameters in values.yaml. These parameters were previously undocumented or lacked specific details regarding their required internal Kubernetes Secret keys and fallback behaviors.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.