Skip to content

[AIRFLOW-5746] move FakeDateTime into the only place it is used#6416

Merged
potiuk merged 1 commit intoapache:masterfrom
mr-c:faketime_fix
Oct 24, 2019
Merged

[AIRFLOW-5746] move FakeDateTime into the only place it is used#6416
potiuk merged 1 commit intoapache:masterfrom
mr-c:faketime_fix

Conversation

@mr-c
Copy link
Contributor

@mr-c mr-c commented Oct 24, 2019 •
edited
Loading

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"

https://issues.apache.org/jira/browse/AIRFLOW-5746

Description

  • Fixes the database upgrade. No UI changes

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: Fixes the database upgrade

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

@mr-c mr-c changed the title move FakeDateTime into the only place it is used [AIRFLOW-5746] move FakeDateTime into the only place it is used Oct 24, 2019
@mr-c @potiuk
[AIRFLOW-5746] move FakeDateTime into the only place it is used
8c90f23 
Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
@potiuk potiuk merged commit adfcf67 into apache:master Oct 24, 2019
@mr-c mr-c deleted the faketime_fix branch October 24, 2019 17:50
potiuk added a commit that referenced this pull request Oct 24, 2019
@mr-c @potiuk
[AIRFLOW-5746] move FakeDateTime into the only place it is used (#6416)
b7798b7 
Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
(cherry picked from commit adfcf67)
@mik-laj
Copy link
Member

mik-laj commented Oct 25, 2019

This PR is not valid because this package is intentionally pulled into a separate file.
More information: #6098 (comment)

mik-laj pushed a commit to PolideaInternal/airflow that referenced this pull request Oct 25, 2019
Revert "[AIRFLOW-5746] move FakeDateTime into the only place it is us…
37376ca 
…ed (apache#6416)"

This reverts commit adfcf67.
ashb pushed a commit to ashb/airflow that referenced this pull request Oct 25, 2019
@mr-c @potiuk @ashb
[AIRFLOW-5746] move FakeDateTime into the only place it is used (apac…
7a6adad 
…he#6416)

Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
(cherry picked from commit adfcf67)
mik-laj pushed a commit to PolideaInternal/airflow that referenced this pull request Oct 26, 2019
fixup! Revert "[AIRFLOW-5746] move FakeDateTime into the only place i…
e7ed6dd 
…t is used (apache#6416)"
potiuk added a commit that referenced this pull request Oct 29, 2019
@mr-c @potiuk
[AIRFLOW-5746] move FakeDateTime into the only place it is used (#6416)
9946664 
Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
(cherry picked from commit adfcf67)
potiuk added a commit that referenced this pull request Nov 12, 2019
@mr-c @potiuk
[AIRFLOW-5746] move FakeDateTime into the only place it is used (#6416)
2cb4dfd 
Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
(cherry picked from commit adfcf67)
eladkal pushed a commit to eladkal/airflow that referenced this pull request Dec 2, 2019
@mr-c @potiuk @eladkal
[AIRFLOW-5746] move FakeDateTime into the only place it is used (apac…
a523a49 
…he#6416)

Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
(cherry picked from commit adfcf67)
kaxil pushed a commit that referenced this pull request Dec 12, 2019
@mr-c @potiuk @kaxil
[AIRFLOW-5746] move FakeDateTime into the only place it is used (#6416)
4bb56cf 
Co-authored-by: Jarek Potiuk <jarek.potiuk@polidea.com>
(cherry picked from commit adfcf67)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@Fokko Fokko Fokko approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mr-c @mik-laj @potiuk @Fokko