Teardown Waiting for All in-scope Tasks to Complete#64181
Merged
jscheffl merged 6 commits intoapache:mainfrom Mar 25, 2026
Merged
Conversation
Contributor
|
@huashi-st Ask please @jscheffl to review. Nice patch 👍 |
Nataneljpwd
reviewed
Mar 25, 2026
Contributor
Nataneljpwd
left a comment
There was a problem hiding this comment.
Looks great!
Some minor improvements can be done, otherwise looks great
jscheffl
approved these changes
Mar 25, 2026
Contributor
jscheffl
left a comment
There was a problem hiding this comment.
Looks good! Am a bit envy because I attempted a fix also (some time ago) and failed in making pytests work. But seems you mastered it! Thanks!
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix teardown tasks firing before all in-scope tasks complete.
Previously, teardown only checked direct upstream states, so it could run while cleared or parallel in-scope tasks were still executing. adds
_evaluate_teardown_scope()to verify all tasks between setup and teardown have reached a terminal state before proceeding.closes: #29332
Test Dag
Before (at the time
task_failfailed) -After (at the time
task_failfailed) -Was generative AI tooling used to co-author this PR?
Generated-by: Claude (Cursor) following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.