chore(elasticsearch): remove elasticmock from task handler tests#64200
Merged
eladkal merged 1 commit intoapache:mainfrom Mar 25, 2026
Merged
chore(elasticsearch): remove elasticmock from task handler tests#64200eladkal merged 1 commit intoapache:mainfrom
eladkal merged 1 commit intoapache:mainfrom
Conversation
eladkal
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Elasticsearch task handler unit tests to stop relying on the in-process elasticmock fake. The suite now uses explicit mocked Elasticsearch responses and direct client mocks, which makes the tests easier to read and closer to the real code paths we own.
This also prunes a few low-value or redundant cases, tightens assertions in the remaining tests, and removes the old elasticmock helper package.