Pass parameters to k8s methods conditionally to fix mypy#64242
Merged
eladkal merged 2 commits intoapache:mainfrom Mar 26, 2026
Merged
Pass parameters to k8s methods conditionally to fix mypy#64242eladkal merged 2 commits intoapache:mainfrom
eladkal merged 2 commits intoapache:mainfrom
Conversation
Nataneljpwd
approved these changes
Mar 26, 2026
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/hooks/kubernetes.py
Show resolved
Hide resolved
Lee-W
approved these changes
Mar 26, 2026
eladkal
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
As seen in https://github.com/apache/airflow/actions/runs/23577516559/job/68654632264?pr=64239
There were some issues here.
container_name (typed as str | None)passed to parameter expectingstrsince_seconds (typed as int | None)passed to parameter expectingintFix is to use conditional parameter passing - only include optional parameters when they have non-None values:
resource_version (typed as str | None)passed to parameter expectingstrConditional expression "NotOlderThan" if
resource_versionelseNoneevaluated tostr | Nonebut expectedstrFix is to only include both resource_version and resource_version_match when resource_version is not None
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.