Skip to content

open task group when navigating via group name; preserve arrow toggl…#64284

Merged
bbovenzi merged 7 commits intoapache:mainfrom
fat-catTW:grid-view-task-group-expand-hitbox-too-small
Apr 8, 2026
Merged

open task group when navigating via group name; preserve arrow toggl…#64284
bbovenzi merged 7 commits intoapache:mainfrom
fat-catTW:grid-view-task-group-expand-hitbox-too-small

Conversation

@fat-catTW
Copy link
Copy Markdown
Contributor

@fat-catTW fat-catTW commented Mar 27, 2026 •
edited by pierrejeambrun
Loading

Why:

Users find the chevron hard to use. It’s too small.
closes: #64208

Solution:

When clicking a group name:

  • If not viewing that group and it’s closed → immediately add the group id to openGroupIds (de-duplicated) before navigation.
  • If not viewing that group and it’s already open → navigate to the group details and keep the group open.
  • If already viewing that group → call the debounced toggle (same as chevron).
  • Chevron click behavior unchanged (still toggles inline and prevents navigation).
Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Copliot following the guidelines

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Mar 27, 2026
@fat-catTW fat-catTW marked this pull request as ready for review March 27, 2026 11:25
pierrejeambrun
pierrejeambrun reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. A few suggestions to make the code cleaner. (Also it wasn't behaving as expected locally but it will with the suggestions)

@kaxil kaxil requested a review from Copilot April 2, 2026 00:43
Copilot AI reviewed Apr 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Grid View task-group row interaction so clicking the task-group name (not just the chevron) will open the group appropriately and preserve open state when navigating into the group, addressing the small chevron hitbox reported in #64208.

Changes:

  • Extends useOpenGroups() usage in TaskNames to read/write openGroupIds in addition to toggling.
  • Adds link-click logic for task-group rows to (a) toggle when already viewing the group, or (b) ensure the group is open before navigating into it.
  • Replaces the group-name RouterLink onClick handler to run the new pre-navigation open/toggle logic plus the existing onRowClick callback.

@potiuk potiuk added the ready for maintainer review Set after triaging when all criteria pass. label Apr 2, 2026
@pierrejeambrun pierrejeambrun removed the ready for maintainer review Set after triaging when all criteria pass. label Apr 3, 2026
@pierrejeambrun pierrejeambrun marked this pull request as draft April 3, 2026 13:36
@pierrejeambrun
Copy link
Copy Markdown
Member

pierrejeambrun commented Apr 3, 2026

Converting to draft since there are some review comments and small changes to be implemented before we can re-review this. (and probably merge it)

fat-catTW and others added 2 commits April 3, 2026 23:34
@fat-catTW @pierrejeambrun
Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames…
580d8c3 
….tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@fat-catTW @pierrejeambrun
Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames…
7f938b1 
….tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@fat-catTW fat-catTW marked this pull request as ready for review April 4, 2026 03:21
pierrejeambrun
pierrejeambrun approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just pushed a small commit to fix the CI

@pierrejeambrun pierrejeambrun added this to the Airflow 3.2.1 milestone Apr 8, 2026
@pierrejeambrun pierrejeambrun added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 8, 2026
@bbovenzi bbovenzi merged commit 11a0aa8 into apache:main Apr 8, 2026
82 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 8, 2026
@fat-catTW @potiuk @pierrejeambrun
[v3-2-test] open task group when navigating via group name; preserve …
8ddd773 
…arrow toggl… (#64284)

* open task group when navigating via group name; preserve arrow toggle behavior

* Remove redundant comment.

* Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* Fixing static checks

* Update TaskNames.tsx

---------
(cherry picked from commit 11a0aa8)

Co-authored-by: fat-catTW <124506982+fat-catTW@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
✅ v3-2-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 8, 2026
@fat-catTW @potiuk @pierrejeambrun
[v3-2-test] open task group when navigating via group name; preserve …
e649d3d 
…arrow toggl… (apache#64284)

* open task group when navigating via group name; preserve arrow toggle behavior

* Remove redundant comment.

* Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames.tsx

Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>

* Fixing static checks

* Update TaskNames.tsx

---------
(cherry picked from commit 11a0aa8)

Co-authored-by: fat-catTW <124506982+fat-catTW@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
pierrejeambrun added a commit that referenced this pull request Apr 9, 2026
@github-actions @fat-catTW
@potiuk @pierrejeambrun
[v3-2-test] open task group when navigating via group name; preserve …
010ba65 
…arrow toggl… (#64284) (#64919)

* open task group when navigating via group name; preserve arrow toggle behavior

* Remove redundant comment.

* Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames.tsx



* Update airflow-core/src/airflow/ui/src/layouts/Details/Grid/TaskNames.tsx



* Fixing static checks

* Update TaskNames.tsx

---------
(cherry picked from commit 11a0aa8)

Co-authored-by: fat-catTW <124506982+fat-catTW@users.noreply.github.com>
Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pierrejeambrun pierrejeambrun pierrejeambrun approved these changes

@bbovenzi bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

@ryanahamilton ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

@shubhamraj-git shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

@guan404ming guan404ming Awaiting requested review from guan404ming guan404ming is a code owner

@vatsrahul1001 vatsrahul1001 Awaiting requested review from vatsrahul1001 vatsrahul1001 is a code owner

@choo121600 choo121600 Awaiting requested review from choo121600 choo121600 is a code owner

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Milestone

Airflow 3.2.1

Development

Successfully merging this pull request may close these issues.

Airflow 3 grid view task group expand hitbox too small

5 participants

@fat-catTW @pierrejeambrun @potiuk @bbovenzi