Fix ts-compile-lint-simple-auth-manager-ui prek hook#64310
Merged
pierrejeambrun merged 2 commits intoapache:mainfrom Mar 30, 2026
Merged
Fix ts-compile-lint-simple-auth-manager-ui prek hook#64310pierrejeambrun merged 2 commits intoapache:mainfrom
pierrejeambrun merged 2 commits intoapache:mainfrom
Conversation
pierrejeambrun
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
vincbeck
as code owners
boring-cyborg
bot
added
area:API
Member
Author
|
Now that the hook is actually running CI should fail. I realized that the hook was silently failing while working on #64303 that fixes the linting errors. |
vincbeck
approved these changes
Mar 27, 2026
amoghrajesh
approved these changes
Mar 27, 2026
eladkal
approved these changes
Mar 27, 2026
pierrejeambrun
force-pushed
the
fix/simple-auth-manager-ui-prek-hook
branch
from
d597ae9 to
f62b468
Compare
pierrejeambrun
commented
Mar 27, 2026
airflow-core/src/airflow/api_fastapi/auth/managers/simple/ui/pnpm-lock.yaml
Show resolved
Hide resolved
jscheffl
approved these changes
Mar 28, 2026
potiuk
approved these changes
Mar 30, 2026
The hook was silently failing due to two issues: - Used AIRFLOW_ROOT_PATH instead of AIRFLOW_CORE_ROOT_PATH for relative path computation, causing file matching to fail silently. - The minimatch pnpm override forced all minimatch to v10+, breaking eslint-plugin-react which requires minimatch v3 (default export as function). Aligned overrides with the main UI's version-range-aware approach.
pierrejeambrun
force-pushed
the
fix/simple-auth-manager-ui-prek-hook
branch
from
f62b468 to
93b2f1a
Compare
1 task
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Apr 3, 2026
* Fix ts-compile-lint-simple-auth-manager-ui prek hook The hook was silently failing due to two issues: - Used AIRFLOW_ROOT_PATH instead of AIRFLOW_CORE_ROOT_PATH for relative path computation, causing file matching to fail silently. - The minimatch pnpm override forced all minimatch to v10+, breaking eslint-plugin-react which requires minimatch v3 (default export as function). Aligned overrides with the main UI's version-range-aware approach. * Fix static checks
Suraj-kumar00
pushed a commit
to Suraj-kumar00/airflow
that referenced
this pull request
Apr 7, 2026
* Fix ts-compile-lint-simple-auth-manager-ui prek hook The hook was silently failing due to two issues: - Used AIRFLOW_ROOT_PATH instead of AIRFLOW_CORE_ROOT_PATH for relative path computation, causing file matching to fail silently. - The minimatch pnpm override forced all minimatch to v10+, breaking eslint-plugin-react which requires minimatch v3 (default export as function). Aligned overrides with the main UI's version-range-aware approach. * Fix static checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hook was silently failing due to two issues:
Was generative AI tooling used to co-author this PR?
Generated-by: [Cursor] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.