Skip to content

Remove false-positive RFC3986 underscore warning from Connection.get_uri() #64345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
potiuk merged 2 commits into from
Apr 1, 2026
+0 −5
Merged

Remove false-positive RFC3986 underscore warning from Connection.get_uri() #64345

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccb260e
Remove false-positive RFC3986 underscore warning from Connection.get_…
MichaelRBlack Mar 28, 2026
033d8e0
Merge branch 'main' into fix/secrets-connection-deprecation-warnings
MichaelRBlack Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions task-sdk/src/airflow/sdk/definitions/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,11 +157,6 @@ def get_uri(self) -> str:
"""Generate and return connection in URI format."""
from urllib.parse import parse_qsl

if self.conn_type and "_" in self.conn_type:
log.warning(
"Connection schemes (type: %s) shall not contain '_' according to RFC3986.",
self.conn_type,
)
if self.conn_type:
uri = f"{self.conn_type.lower().replace('_', '-')}://"
else:
Expand Down
Loading