[AIRFLOW-5759] Don't allow additional arguments in BaseOperator

[mik-laj]

Make sure you have checked all steps below.

Jira

• My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-XXX
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
  • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

[codecov-io]

Codecov Report

Merging #6435 into master will decrease coverage by 0.35%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #6435      +/-   ##
=========================================
- Coverage   84.26%   83.9%   -0.36%     
=========================================
  Files         627     627              
  Lines       36506   36512       +6     
=========================================
- Hits        30760   30634     -126     
- Misses       5746    5878     +132

Impacted Files	Coverage Δ
airflow/models/baseoperator.py	95.93% <ø> (ø)	⬆️
airflow/contrib/operators/qubole_check_operator.py	72.09% <100%> (+0.32%)	⬆️
...ow/contrib/example_dags/example_qubole_operator.py	32.5% <0%> (-57.5%)	⬇️
airflow/kubernetes/volume_mount.py	44.44% <0%> (-55.56%)	⬇️
airflow/kubernetes/volume.py	52.94% <0%> (-47.06%)	⬇️
airflow/kubernetes/pod_launcher.py	45.25% <0%> (-46.72%)	⬇️
airflow/kubernetes/kube_client.py	33.33% <0%> (-41.67%)	⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py	70.14% <0%> (-28.36%)	⬇️
airflow/gcp/example_dags/example_dataflow.py	93.33% <0%> (-6.67%)	⬇️
airflow/utils/dag_processing.py	58.15% <0%> (-0.33%)	⬇️
... and 6 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e440da...b3f8574. Read the comment docs.

[feluelle]

LGTM 👍

Only one suggestion: Isn't it more like "Don't allow additional arguments in BaseOperator by default", because you can still change this setting.

[mik-laj]

@feluelle

Subject is limited to 50 characters (not including Jira issue reference)

Don't allow additional arguments in BaseOperator = 48 characters
Don't allow additional arguments in BaseOperator by default = 59 characters

I prefer shorter to avoid breaking the rules.