[AIRFLOW-5772] Use mock.patch.dict for manipulation of env vars#6444
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6444 +/- ##
==========================================
- Coverage 84.15% 83.69% -0.46%
==========================================
Files 627 627
Lines 36537 36537
==========================================
- Hits 30746 30579 -167
- Misses 5791 5958 +167
Continue to review full report at Codecov.
|
turbaszek
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Side effects when modifying the os.environ variable are often a problem. Using unittest.mock ensures test security and stability, because it guarantees that it restore the dictionary to its original state after the test.
More information: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch.dict
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation