Skip to content

[AIRFLOW-5772] Use mock.patch.dict for manipulation of env vars#6444

Merged
kaxil merged 3 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-5772
Oct 28, 2019
Merged

[AIRFLOW-5772] Use mock.patch.dict for manipulation of env vars#6444
kaxil merged 3 commits into
apache:masterfrom
PolideaInternal:AIRFLOW-5772

Conversation

@mik-laj
Copy link
Copy Markdown
Member

@mik-laj mik-laj commented Oct 27, 2019

Side effects when modifying the os.environ variable are often a problem. Using unittest.mock ensures test security and stability, because it guarantees that it restore the dictionary to its original state after the test.

More information: https://docs.python.org/3/library/unittest.mock.html#unittest.mock.patch.dict


Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 27, 2019

Codecov Report

Merging #6444 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6444      +/-   ##
==========================================
- Coverage   84.15%   83.69%   -0.46%     
==========================================
  Files         627      627              
  Lines       36537    36537              
==========================================
- Hits        30746    30579     -167     
- Misses       5791     5958     +167
Impacted Files Coverage Δ
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/gcp/example_dags/example_vision.py
airflow/gcp/operators/vision.py
airflow/gcp/hooks/vision.py
airflow/providers/google/cloud/hooks/vision.py 92.09% <0%> (ø)
...viders/google/cloud/example_dags/example_vision.py 0% <0%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4132f3b...0d9f486. Read the comment docs.

@mik-laj mik-laj requested a review from potiuk October 27, 2019 15:41
Copy link
Copy Markdown
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @mik-laj 👌🏼

Copy link
Copy Markdown
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaxil kaxil merged commit 1f2573a into apache:master Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants