Skip to content

[AIRFLOW-5773] Migrate AWS Athena components to /providers/aws [AIP-21]#6446

Merged
kaxil merged 3 commits into
apache:masterfrom
BasPH:airflow-5773-migrate-aws-athena
Oct 28, 2019
Merged

[AIRFLOW-5773] Migrate AWS Athena components to /providers/aws [AIP-21]#6446
kaxil merged 3 commits into
apache:masterfrom
BasPH:airflow-5773-migrate-aws-athena

Conversation

@BasPH
Copy link
Copy Markdown
Contributor

@BasPH BasPH commented Oct 27, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5773
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

This PR migrates all AWS Athena components to /providers/aws. Since this is the first out of many AWS component to migrate, this PR also creates new modules and __init__.py files in /providers/aws and required config in docs.

Related PR migrating all AWS components, but decided to split because of size: #6439.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@BasPH BasPH requested a review from mik-laj October 27, 2019 10:48
@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 27, 2019

Can you add tests and note in UPDATING.md file?
https://github.com/apache/airflow/blob/master/tests/test_core_to_contrib.py

@BasPH
Copy link
Copy Markdown
Contributor Author

BasPH commented Oct 27, 2019

@mik-laj I don't understand the purpose of this file, what is it actually testing?

@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 27, 2019

@BasPH This tests backwards compatibility. Ensures that the class is still available in the old location. When loading the module from the old location, a message with information about the new location must also be reported. There are also tests in the same file that check if a message is reported when you try to use a class with the old name. This applies to the next steps when changing operator names. This test is very important because it makes it much easier to verify the correctness of the change.

Another saying. This facilitates the boring review process.

@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 27, 2019

Can you add a note in UPDATING.md file? Sorry to create confusion and I didn't say it before. Ie. I said in the edited comment, but Github may not have refreshed the comment.

@BasPH
Copy link
Copy Markdown
Contributor Author

BasPH commented Oct 27, 2019

Added tests & section to UPDATING.md.

@mik-laj
Copy link
Copy Markdown
Member

mik-laj commented Oct 27, 2019

Awesome.

@feluelle feluelle added the provider:amazon AWS/Amazon - related issues label Oct 27, 2019
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 27, 2019

Codecov Report

Merging #6446 into master will decrease coverage by 0.16%.
The diff coverage is 78.2%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6446      +/-   ##
==========================================
- Coverage   83.85%   83.69%   -0.17%     
==========================================
  Files         627      630       +3     
  Lines       36537    36549      +12     
==========================================
- Hits        30639    30590      -49     
- Misses       5898     5959      +61
Impacted Files Coverage Δ
airflow/providers/aws/sensors/athena.py 100% <100%> (ø)
airflow/contrib/operators/aws_athena_operator.py 100% <100%> (+26%) ⬆️
airflow/contrib/sensors/aws_athena_sensor.py 100% <100%> (ø) ⬆️
airflow/contrib/hooks/aws_athena_hook.py 100% <100%> (+32.81%) ⬆️
airflow/providers/aws/hooks/athena.py 67.18% <67.18%> (ø)
airflow/providers/aws/operators/athena.py 74% <74%> (ø)
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2caa45...3141fad. Read the comment docs.

@kaxil kaxil merged commit 59b6d8b into apache:master Oct 28, 2019
@BasPH BasPH deleted the airflow-5773-migrate-aws-athena branch October 28, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants