[AIRFLOW-5773] Migrate AWS Athena components to /providers/aws [AIP-21]#6446
Conversation
|
Can you add tests and note in UPDATING.md file? |
|
@mik-laj I don't understand the purpose of this file, what is it actually testing? |
|
@BasPH This tests backwards compatibility. Ensures that the class is still available in the old location. When loading the module from the old location, a message with information about the new location must also be reported. There are also tests in the same file that check if a message is reported when you try to use a class with the old name. This applies to the next steps when changing operator names. This test is very important because it makes it much easier to verify the correctness of the change. Another saying. This facilitates the boring review process. |
|
Can you add a note in UPDATING.md file? Sorry to create confusion and I didn't say it before. Ie. I said in the edited comment, but Github may not have refreshed the comment. |
|
Added tests & section to UPDATING.md. |
|
Awesome. |
Codecov Report
@@ Coverage Diff @@
## master #6446 +/- ##
==========================================
- Coverage 83.85% 83.69% -0.17%
==========================================
Files 627 630 +3
Lines 36537 36549 +12
==========================================
- Hits 30639 30590 -49
- Misses 5898 5959 +61
Continue to review full report at Codecov.
|
Make sure you have checked all steps below.
Jira
Description
This PR migrates all AWS Athena components to
/providers/aws. Since this is the first out of many AWS component to migrate, this PR also creates new modules and__init__.pyfiles in/providers/awsand required config in docs.Related PR migrating all AWS components, but decided to split because of size: #6439.
Tests
Commits
Documentation