Add retries for _write_logs method in KubernetesPodOperator#64471
Open
wolfdn wants to merge 3 commits intoapache:mainfrom
Open
Add retries for _write_logs method in KubernetesPodOperator#64471wolfdn wants to merge 3 commits intoapache:mainfrom
_write_logs method in KubernetesPodOperator#64471wolfdn wants to merge 3 commits intoapache:mainfrom
Conversation
Contributor
|
@wolfdn Backcompat tests are failing, can you check these? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds retries using Tenacity to the
_write_logsmethod inKubernetesPodOperator.Previously, this method was logging
Reading of logs interrupted with error ...; will retry.when it encountered an ApiException or HTTPError - but actually it did not retry (maybe the retry logic went missing during some refactoring?).Apart from adding retries, the behaviour is kept the same: If all retries fail,
KubernetesPodOperatorwill print another warning but then proceed with pod cleanup.Other changes
from airflow.utils import timezonewithfrom airflow.sdk import timezone- this was consistently failing for me in pre-push hooks otherwise, I assume this is needed nowtest_async_write_logs_handler_api_exceptiontestWas generative AI tooling used to co-author this PR?
GitHub Copilot - Claude Opus 4.6
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.