Skip to content

[AIRFLOW-XXX] Local development environments - polish documentation#6450

Merged
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:further-fixes-for-gsod
Nov 12, 2019
Merged

[AIRFLOW-XXX] Local development environments - polish documentation#6450
potiuk merged 2 commits intoapache:masterfrom
PolideaInternal:further-fixes-for-gsod

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Oct 27, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@potiuk potiuk changed the title Starting editing of the LOCA_VIRTUALENv Further fixes for GSOD Oct 27, 2019
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to move the section BREEZE.rst#debugging-airflow-breeze-tests-in-ide to this doc. Do you think it makes sense?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. That should be OK. However just thinking maybe we should have a separate TESTING.rst for example that we could describe both - testing with local virtualenv and Breeze? Just a thought - I do not feel strong about it, but I think since we already have few documents, it might make sense ? What do you think? I think you mentioned once that it's better to have one doc rather than many, but maybe in this case this will be justified since we can have links between the docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's beef them up first and see whether more granular docs are required. Actually, adding a TOC pane would help to navigate in a bigger doc...

@potiuk
Copy link
Member Author

potiuk commented Nov 4, 2019

One thing that we might add here is using pyenv (https://github.com/pyenv/pyenv) and pyenv-virtualenv (https://github.com/pyenv/pyenv-virtualenv) rather than virtualenvrapper (or as another alternative). It seems to be more "modern" and preferred by a number of people.

@potiuk potiuk force-pushed the further-fixes-for-gsod branch from 7a12224 to bb269c3 Compare November 4, 2019 14:35
@potiuk potiuk marked this pull request as ready for review November 4, 2019 14:35
@potiuk potiuk force-pushed the further-fixes-for-gsod branch 2 times, most recently from 4452ae0 to aee6770 Compare November 4, 2019 14:40
@mik-laj mik-laj changed the title Further fixes for GSOD [AIRFLOW-XXX] Local development environments - polish documentation Nov 4, 2019
Copy link
Member Author

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it !

Co-authored-by: Elena Fedotova <lavel@mail.ru>
@potiuk potiuk force-pushed the further-fixes-for-gsod branch from 2f2db7b to 8dd85f1 Compare November 12, 2019 14:56
@potiuk potiuk requested review from kaxil and mik-laj November 12, 2019 14:57
@potiuk
Copy link
Member Author

potiuk commented Nov 12, 2019

Next round of doc fixes by @efedotova (@kaxil @mik-laj )?

Co-Authored-By: Kaxil Naik <kaxilnaik@gmail.com>
@potiuk potiuk merged commit 238e154 into apache:master Nov 12, 2019
GnunuX pushed a commit to GnunuX/airflow that referenced this pull request Nov 13, 2019
…pache#6450)

* [AIRFLOW-XXX] Updates to LOCAL_VIRTUALENV.rst

Co-authored-by: Elena Fedotova <lavel@mail.ru>
Co-Authored-By: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants