fix(ui): correct external link target and add rel attributes#64542
fix(ui): correct external link target and add rel attributes#64542bbovenzi merged 4 commits intoapache:mainfrom
Conversation
|
Hey @Mayankaggarwal8055 - |
|
@Mayankaggarwal8055 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
There was a problem hiding this comment.
Pull request overview
This PR fixes Airflow UI documentation links that were 404’ing when the running Airflow version didn’t have published docs (e.g., dev/unreleased versions), and corrects external-link behavior.
Changes:
- Point docs links to the
stabledocumentation instead of version-specific docs. - Fix external link attributes (
target="_blank"+rel="noopener noreferrer"). - Add tests covering the updated link targets.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| airflow-core/src/airflow/ui/src/pages/Connections/NothingFoundInfo.tsx | Switch connection docs link to stable and fix external link attributes. |
| airflow-core/src/airflow/ui/src/pages/Connections/NothingFoundInfo.test.tsx | Add test asserting stable docs URL and correct link attributes. |
| airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.tsx | Switch “version” docs menu item to use stable docs index URL. |
| airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.test.tsx | Add test ensuring the version menu item points to the stable docs index URL. |
airflow-core/src/airflow/ui/src/pages/Connections/NothingFoundInfo.tsx
Outdated
Show resolved
Hide resolved
pierrejeambrun
left a comment
There was a problem hiding this comment.
It appears that his is always using the 'stable' link and not the 'version' one anymore.
I don't think that's the correct approach.
Can you spin up a different PR for fixing the blank and other attributes link, so we can get that merged easily without waiting for resolution of the stable/version doc.
|
Thanks for the feedback! I’ll run the pre-commit checks locally and fix all the failing issues. I’ll also address the test failures and update the PR accordingly. Will push the updates soon and mark it ready for review once everything passes. |
435bc0f to
4900189
Compare
4900189 to
e7f0a68
Compare
|
The PR has different language description |
|
Please fix it - your PRs keep on having strange issues showing that you have not looked at them this is a warning sign that will make your PRs go by default in draft/close queue if it does not improve. If you use agents you are still responsible for the code you submit so be careful |
|
Sorry @potuik for the issues earlier — I realize I should have reviewed the PR more carefully before submitting. I’ve now run and also updated the pr description to official language used. I’ll keep investigating, but if there’s anything specific I might be missing, I’d really appreciate your guidance. |
1fb3dbe to
2eede5d
Compare
…tes (#64542) * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix: apply UI formatting (cherry picked from commit 8509dc9) Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
…tes (apache#64542) * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix: apply UI formatting (cherry picked from commit 8509dc9) Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
…tes (#64542) (#64772) * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix: apply UI formatting (cherry picked from commit 8509dc9) Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
…tes (#64542) (#64772) * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix(ui): correct external link target and add rel attributes with test * fix: apply UI formatting (cherry picked from commit 8509dc9) Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
#64541
Problem
Additionally,
NothingFoundInfo.tsxwas usingtarget="blank"instead of the correcttarget="_blank".Changes
target="_blank"withrel="noopener noreferrer"Result