Skip to content

fix(ui): correct external link target and add rel attributes#64542

Merged
bbovenzi merged 4 commits intoapache:mainfrom
Mayankaggarwal8055:fix-docs-links-clean
Apr 6, 2026
Merged

fix(ui): correct external link target and add rel attributes#64542
bbovenzi merged 4 commits intoapache:mainfrom
Mayankaggarwal8055:fix-docs-links-clean

Conversation

@Mayankaggarwal8055
Copy link
Copy Markdown
Contributor

@Mayankaggarwal8055 Mayankaggarwal8055 commented Mar 31, 2026

#64541

Problem

Additionally, NothingFoundInfo.tsx was using target="blank" instead of the correct target="_blank".

Changes

  • Updated external link attributes to use target="_blank" with rel="noopener noreferrer"
  • Added tests to verify correct link behavior

Result

  • External links now open securely in a new tab
  • Link attributes follow best practices

@Srabasti
Copy link
Copy Markdown
Contributor

Srabasti commented Apr 1, 2026

Hey @Mayankaggarwal8055 -
Static checks are failing. Can you run prek locally and then commit your branch to repo?
Static checks fail ho rahe hain. Kya aap apane local par prek chalaakar, phir apne branch ko repo mein commit kar sakte hain?

@potiuk potiuk marked this pull request as draft April 1, 2026 12:34
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 1, 2026

@Mayankaggarwal8055 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

  • Pre-commit / static checks: Failing: CI image checks / Static checks. Run prek run --from-ref main locally to find and fix issues. See Pre-commit / static checks docs.
  • Other failing CI checks: Failing: Basic tests / React UI tests, Additional PROD image tests / Chromium UI e2e tests with PROD image / Chromium UI e2e tests. Run prek run --from-ref main locally to reproduce. See static checks docs.

What to do next:

  • The comment informs you what you need to do.
  • Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
  • There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates.
  • Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack.

@kaxil kaxil requested a review from Copilot April 2, 2026 00:41
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes Airflow UI documentation links that were 404’ing when the running Airflow version didn’t have published docs (e.g., dev/unreleased versions), and corrects external-link behavior.

Changes:

  • Point docs links to the stable documentation instead of version-specific docs.
  • Fix external link attributes (target="_blank" + rel="noopener noreferrer").
  • Add tests covering the updated link targets.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
airflow-core/src/airflow/ui/src/pages/Connections/NothingFoundInfo.tsx Switch connection docs link to stable and fix external link attributes.
airflow-core/src/airflow/ui/src/pages/Connections/NothingFoundInfo.test.tsx Add test asserting stable docs URL and correct link attributes.
airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.tsx Switch “version” docs menu item to use stable docs index URL.
airflow-core/src/airflow/ui/src/layouts/Nav/DocsButton.test.tsx Add test ensuring the version menu item points to the stable docs index URL.

Copy link
Copy Markdown
Member

@pierrejeambrun pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that his is always using the 'stable' link and not the 'version' one anymore.

I don't think that's the correct approach.

Can you spin up a different PR for fixing the blank and other attributes link, so we can get that merged easily without waiting for resolution of the stable/version doc.

@Mayankaggarwal8055
Copy link
Copy Markdown
Contributor Author

Thanks for the feedback!

I’ll run the pre-commit checks locally and fix all the failing issues. I’ll also address the test failures and update the PR accordingly.

Will push the updates soon and mark it ready for review once everything passes.

@Mayankaggarwal8055 Mayankaggarwal8055 marked this pull request as ready for review April 4, 2026 15:42
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 4, 2026

The PR has different language description

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Apr 4, 2026

Please fix it - your PRs keep on having strange issues showing that you have not looked at them this is a warning sign that will make your PRs go by default in draft/close queue if it does not improve. If you use agents you are still responsible for the code you submit so be careful

@Mayankaggarwal8055 Mayankaggarwal8055 changed the title Fix: UI me docs links 404 de rahe the (stable docs + target fix) fix(ui): correct external link target and add rel attributes Apr 4, 2026
@Mayankaggarwal8055
Copy link
Copy Markdown
Contributor Author

Mayankaggarwal8055 commented Apr 4, 2026

Sorry @potuik for the issues earlier — I realize I should have reviewed the PR more carefully before submitting.

I’ve now run prek run --all-files locally and applied all the changes. However, one of the checks is still failing on CI, and I’m not sure why. At the moment, another check is still in progress.

and also updated the pr description to official language used.

I’ll keep investigating, but if there’s anything specific I might be missing, I’d really appreciate your guidance.

@bbovenzi bbovenzi added this to the Airflow 3.2.1 milestone Apr 6, 2026
@bbovenzi bbovenzi added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 6, 2026
@bbovenzi bbovenzi merged commit 8509dc9 into apache:main Apr 6, 2026
84 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 6, 2026
…tes (#64542)

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix: apply UI formatting
(cherry picked from commit 8509dc9)

Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

Backport successfully created: v3-2-test

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
v3-2-test PR Link

github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Apr 6, 2026
…tes (apache#64542)

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix: apply UI formatting
(cherry picked from commit 8509dc9)

Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
bbovenzi pushed a commit that referenced this pull request Apr 6, 2026
…tes (#64542) (#64772)

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix: apply UI formatting
(cherry picked from commit 8509dc9)

Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
vatsrahul1001 pushed a commit that referenced this pull request Apr 8, 2026
…tes (#64542) (#64772)

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix(ui): correct external link target and add rel attributes with test

* fix: apply UI formatting
(cherry picked from commit 8509dc9)

Co-authored-by: Mayank Aggarwal <aggarwalmayank184@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants