Skip to content

[AIRFLOW-5739] Move google cloud platform functions to providers package#6456

Closed
chicochico wants to merge 2 commits intoapache:masterfrom
chicochico:AIRFLOW-5739
Closed

[AIRFLOW-5739] Move google cloud platform functions to providers package#6456
chicochico wants to merge 2 commits intoapache:masterfrom
chicochico:AIRFLOW-5739

Conversation

@chicochico
Copy link

…ions

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-5739] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5739
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes: Move google cloud platform functions to providers package

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: Already tested

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@chicochico chicochico changed the title [AIRFLOW-5739] Move airflow.gcp.*.functions to airflow.providers.google.cloud.*.funct… [AIRFLOW-5739] Move google cloud platform functions to providers package Oct 29, 2019
@mik-laj mik-laj added provider:google Google (including GCP) related issues AIP-21 labels Oct 29, 2019
@mik-laj
Copy link
Member

mik-laj commented Dec 12, 2019

Can you add backward compatiblity and add deprecation warnings?

@chicochico
Copy link
Author

@mik-laj I added the warnings and backward compatibility, I also rebased to the current master.

@mik-laj
Copy link
Member

mik-laj commented Dec 26, 2019

Travis is sad. We also have warnings in the airflow.contrib package. Can you update them? Travis is sad. Can you fix it? Can you add tests in https://github.com/apache/airflow/blob/master/tests/test_core_to_contrib.py?

@stale
Copy link

stale bot commented Feb 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Feb 9, 2020
@mik-laj
Copy link
Member

mik-laj commented Feb 9, 2020

Done. I did it while reorganizing the remaining packages.

@mik-laj mik-laj closed this Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments