Merged
Conversation
bugraoz93
reviewed
Apr 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes incorrect error reporting when AIRFLOW_CLI_DEBUG_MODE=true and the main CLI config exists but the debug credentials file is missing, ensuring a debug-specific “missing debug credentials” error is raised instead of the generic “No credentials file found”.
Changes:
- Catch missing debug credentials file separately during
Credentials.load()and raise a debug-specificAirflowCtlCredentialNotFoundException. - Add a regression test covering the “config present + debug creds missing” scenario in debug mode.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
airflow-ctl/src/airflowctl/api/client.py |
Adds targeted FileNotFoundError handling for missing debug credentials to avoid falling into the generic “no credentials file” path. |
airflow-ctl/tests/airflow_ctl/api/test_client.py |
Adds a regression test asserting the correct exception/message when debug creds are missing but the primary config exists. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
47c3361 to
7134379
Compare
bugraoz93
approved these changes
Apr 7, 2026
shivaam
pushed a commit
to shivaam/airflow
that referenced
this pull request
Apr 8, 2026
* Incorrect fallback logic * Apply suggestions from code review Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
AIRFLOW_CLI_DEBUG_MODEis set to true, if the primary config file exists but the debug_credentials file is missing, the system incorrectly reports "No credentials file found" instead of the expected debug-specific error.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.