[v3-2-test] Remove false-positive RFC3986 underscore warning from Connection.get_uri() (#64345)#64607
Merged
vatsrahul1001 merged 1 commit intov3-2-testfrom Apr 2, 2026
Merged
Conversation
…nection.get_uri() (#64345) `get_uri()` warns about underscores in `conn_type`, but standard Airflow connection types like `google_cloud_platform` inherently contain underscores. The warning is not actionable for users since: 1. Standard provider connection types (google_cloud_platform, etc.) are defined with underscores by the providers themselves 2. `get_uri()` already handles this correctly on the very next line by converting underscores to dashes: `self.conn_type.lower().replace('_', '-')` 3. Connections stored via Secrets Manager backends trigger this warning on every connection retrieval during task execution, producing noisy logs with no remediation path The underscore-to-dash conversion in the URI output remains intact, ensuring RFC3986 compliance of the generated URI. (cherry picked from commit b653b4d) Co-authored-by: Michael Black <4128408+MichaelRBlack@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
vatsrahul1001
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get_uri()warns about underscores inconn_type, but standard Airflowconnection types like
google_cloud_platforminherently contain underscores.The warning is not actionable for users since:
defined with underscores by the providers themselves
get_uri()already handles this correctly on the very next line byconverting underscores to dashes:
self.conn_type.lower().replace('_', '-')on every connection retrieval during task execution, producing noisy
logs with no remediation path
The underscore-to-dash conversion in the URI output remains intact,
ensuring RFC3986 compliance of the generated URI.
(cherry picked from commit b653b4d)
Co-authored-by: Michael Black 4128408+MichaelRBlack@users.noreply.github.com
Co-authored-by: Claude Opus 4.6 (1M context) noreply@anthropic.com