Skip to content

[AIRFLOW-5807] Move SFTP from contrib to providers.#6464

Merged
potiuk merged 4 commits intoapache:masterfrom
PolideaInternal:move-sftp-to-core
Dec 9, 2019
Merged

[AIRFLOW-5807] Move SFTP from contrib to providers.#6464
potiuk merged 4 commits intoapache:masterfrom
PolideaInternal:move-sftp-to-core

Conversation

@TobKed
Copy link
Contributor

@TobKed TobKed commented Oct 29, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5807
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj
Copy link
Member

mik-laj commented Oct 29, 2019

@TobKed Travis is sad. Can you fix it?

@mik-laj mik-laj added the AIP-21 label Oct 29, 2019
@TobKed TobKed force-pushed the move-sftp-to-core branch 3 times, most recently from 179a5b0 to 54ff50b Compare November 1, 2019 19:25
@TobKed
Copy link
Contributor Author

TobKed commented Nov 1, 2019

Rebased after fix for broken master.

@codecov-io
Copy link

codecov-io commented Nov 1, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@6f5c8cf). Click here to learn what that means.
The diff coverage is 93.26%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6464   +/-   ##
=========================================
  Coverage          ?   84.56%           
=========================================
  Files             ?      672           
  Lines             ?    37944           
  Branches          ?        0           
=========================================
  Hits              ?    32086           
  Misses            ?     5858           
  Partials          ?        0
Impacted Files Coverage Δ
airflow/contrib/hooks/sftp_hook.py 100% <100%> (ø)
airflow/operators/gcs_to_sftp.py 100% <100%> (ø)
airflow/contrib/operators/sftp_operator.py 100% <100%> (ø)
...ow/providers/google/cloud/operators/sftp_to_gcs.py 100% <100%> (ø)
airflow/contrib/sensors/sftp_sensor.py 100% <100%> (ø)
airflow/providers/sftp/sensors/sftp_sensor.py 100% <100%> (ø)
airflow/providers/sftp/operators/sftp_operator.py 87.67% <87.67%> (ø)
airflow/providers/sftp/hooks/sftp_hook.py 94.84% <94.84%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f5c8cf...4f2938b. Read the comment docs.

@TobKed
Copy link
Contributor Author

TobKed commented Nov 1, 2019

cc @mik-laj

@mik-laj
Copy link
Member

mik-laj commented Nov 1, 2019

We currently have open discussions to move integration to other package.

CC: @potiuk

@TobKed TobKed force-pushed the move-sftp-to-core branch 2 times, most recently from 971a87f to a94eec4 Compare November 22, 2019 13:13
@TobKed TobKed changed the title [AIRFLOW-5807] Move SFTP from contrib to core [AIRFLOW-5807] Move SFTP from contrib to providers Nov 22, 2019
@TobKed
Copy link
Contributor Author

TobKed commented Nov 22, 2019

@potiuk @mik-laj I've moved SFTP hook, operator and sensor to providers/sftp folder.
I've included __init__.py files due to the problem with from tests.test_utils.config import conf_vars (without __init__ files import was not possible)

@TobKed TobKed changed the title [AIRFLOW-5807] Move SFTP from contrib to providers [AIRFLOW-5807] Move SFTP from contrib to providers. Depends on [AIRFLOW-6059] Nov 25, 2019
@TobKed TobKed changed the title [AIRFLOW-5807] Move SFTP from contrib to providers. Depends on [AIRFLOW-6059] [AIRFLOW-5807] Move SFTP from contrib to providers. Dec 5, 2019
@TobKed TobKed force-pushed the move-sftp-to-core branch 3 times, most recently from d901194 to 8136221 Compare December 6, 2019 10:21
@TobKed TobKed force-pushed the move-sftp-to-core branch from f9b765c to 4f2938b Compare December 9, 2019 10:02
@TobKed
Copy link
Contributor Author

TobKed commented Dec 9, 2019

CC @mik-laj @potiuk

@potiuk potiuk merged commit 69629a5 into apache:master Dec 9, 2019
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
* [AIRFLOW-5807] Move SFTP from contrib to core
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants