UI: Add unit tests for errorHandling helpers#64647
Closed
liamkernan wants to merge 4 commits intoapache:mainfrom
Closed
UI: Add unit tests for errorHandling helpers#64647liamkernan wants to merge 4 commits intoapache:mainfrom
liamkernan wants to merge 4 commits intoapache:mainfrom
Conversation
Cover getErrorStatus and createErrorToaster behavior for 403 vs other errors. Signed-off-by: Liam <liamkernan0@gmail.com>
Signed-off-by: Liam <liamkernan0@gmail.com>
Member
|
@liamkernan This PR has been converted to draft because it does not yet meet our Pull Request quality criteria. Issues found:
What to do next:
Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the Airflow Slack. |
Keep the new errorHandling unit test passing local UI checks so the PR can move forward without pre-commit rewriting the file. Made-with: Cursor
Member
|
Please follow.our quality expectations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Vitest coverage for
getErrorStatusandcreateErrorToasterinsrc/utils/errorHandling.ts, including the contract that 403 responses do not trigger the shared error toaster (handled by MutationCache).Testing
npm exec vitest run src/utils/errorHandling.test.ts(fromairflow-core/src/airflow/ui)Was generative AI tooling used to co-author this PR?
Made with Cursor