Skip to content

[AIRFLOW-5787] Moving AWS SQS to /providers/aws.#6474

Merged
mik-laj merged 1 commit intoapache:masterfrom
ishan4488:master
Oct 31, 2019
Merged

[AIRFLOW-5787] Moving AWS SQS to /providers/aws.#6474
mik-laj merged 1 commit intoapache:masterfrom
ishan4488:master

Conversation

@ishan4488
Copy link
Contributor

@ishan4488 ishan4488 commented Oct 30, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-5787
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@mik-laj mik-laj added AIP-21 provider:amazon AWS/Amazon - related issues labels Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 31, 2019

Codecov Report

Merging #6474 into master will decrease coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6474      +/-   ##
==========================================
- Coverage   83.87%   83.47%   -0.41%     
==========================================
  Files         632      635       +3     
  Lines       36644    36657      +13     
==========================================
- Hits        30734    30598     -136     
- Misses       5910     6059     +149
Impacted Files Coverage Δ
airflow/providers/aws/operators/sqs.py 100% <100%> (ø)
airflow/providers/aws/hooks/sqs.py 100% <100%> (ø)
airflow/providers/aws/sensors/sqs.py 100% <100%> (ø)
airflow/contrib/sensors/aws_sqs_sensor.py 100% <100%> (ø) ⬆️
...flow/contrib/operators/aws_sqs_publish_operator.py 100% <100%> (ø) ⬆️
airflow/contrib/hooks/aws_sqs_hook.py 100% <100%> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/executors/sequential_executor.py 47.61% <0%> (-52.39%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 470b2a7...50a58c8. Read the comment docs.

@mik-laj mik-laj merged commit 71cbe7e into apache:master Oct 31, 2019
@potiuk
Copy link
Member

potiuk commented Oct 31, 2019

We have an open discussion in devlist and I think as result the Better place will be providers/amazon/aws . We might redo this one.

@ishan4488
Copy link
Contributor Author

Sure. Had started work on other AWS entities too. Will hold on until the package structure is finalized.

@mingrammer
Copy link
Contributor

mingrammer commented Nov 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants