Harden GitHook SSH command building and URL construction#64756
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 6, 2026
Merged
Harden GitHook SSH command building and URL construction#64756potiuk merged 1 commit intoapache:mainfrom
potiuk merged 1 commit intoapache:mainfrom
Conversation
- Quote user-controlled values in _build_ssh_command with shlex.quote - Validate strict_host_key_checking against allowlist of valid SSH values - URL-encode username and auth token when embedding in repo URLs - Fix logic bug: `not X or not Y` → `not X and not Y` for git@/https:// check - Limit str.replace to first occurrence
eladkal
approved these changes
Apr 6, 2026
jscheffl
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_build_ssh_commandwithshlex.quotestrict_host_key_checkingagainst allowlist of valid SSH valuesnot X or not Y→not X and not Yforgit@/https://checkstr.replaceto first occurrenceWas generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.6) following the guidelines