Run non-provider mypy as regular prek static checks instead of separate CI jobs#64780
Merged
potiuk merged 1 commit intoapache:mainfrom Apr 6, 2026
Merged
Conversation
potiuk
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
dheerajturaga,
ephraimbuddy,
gopidesupavan,
jason810496,
jedcunningham,
jscheffl,
kaxil,
shahar1 and
vatsrahul1001
as code owners
boring-cyborg
bot
added
area:airflow-ctl
area:dev-tools
area:logging
area:registry
area:task-sdk
backport-to-v3-2-test
jscheffl
reviewed
Apr 6, 2026
Member
Author
|
Actually - we can remove a lot more code now - let me update the PR shortly |
Member
Author
|
We will also get rid of most of the |
potiuk
changed the title
potiuk
force-pushed
the
run-mypy-locally-for-non-providers
branch
3 times, most recently
from
dfc4ce7 to
a73c93a
Compare
… separate CI jobs Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations).
potiuk
force-pushed
the
run-mypy-locally-for-non-providers
branch
from
a73c93a to
01a0962
Compare
bugraoz93
approved these changes
Apr 6, 2026
Contributor
Backport failed to create: v3-2-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 0ce1dd7 v3-2-testThis should apply the commit to the v3-2-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Apr 6, 2026
…s instead of separate CI jobs (apache#64780) Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations). (cherry picked from commit 0ce1dd7) Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
1 task
potiuk
added a commit
that referenced
this pull request
Apr 6, 2026
…s instead of separate CI jobs (#64780) (#64810) Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations). (cherry picked from commit 0ce1dd7)
shivaam
pushed a commit
to shivaam/airflow
that referenced
this pull request
Apr 8, 2026
… separate CI jobs (apache#64780) Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations).
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 8, 2026
…s instead of separate CI jobs (#64780) (#64810) Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations). (cherry picked from commit 0ce1dd7)
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…s instead of separate CI jobs (#64780) (#64810) Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations). (cherry picked from commit 0ce1dd7)
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…s instead of separate CI jobs (#64780) (#64810) Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run locally via uv as regular prek hooks in the pre-commit stage, instead of running as separate mypy CI jobs in the CI image checks workflow. This means they run as part of the regular static checks job in CI and automatically on every local commit. The folder-level mypy checks (which check entire directories at once for comprehensive cross-file type checking) replace the previous file-level incremental checks. Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main CI workflow (ci-amd-arm.yml) instead of being dispatched through the ci-image-checks reusable workflow. The selective checks logic skips non-provider mypy hooks when their relevant files haven't changed, unless devel-common/pyproject.toml changes on main (which affects all mypy configurations). (cherry picked from commit 0ce1dd7)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-provider mypy checks (airflow-core, task-sdk, airflow-ctl, dev, scripts, devel-common) now run
locally via
uvas regular prek hooks in thepre-commitstage. They run as part of the regularstatic checks job in CI and automatically on every local commit — no separate mypy CI jobs needed.
The folder-level mypy checks (which check entire directories at once for comprehensive cross-file
type checking) replace the previous file-level incremental checks.
Provider mypy checks still run via breeze as a dedicated CI job, now embedded directly in the main
CI workflow (
ci-amd-arm.yml) instead of being dispatched through theci-image-checksreusableworkflow. The
mypy-checksselective check output is replaced by a simplerrun-mypy-providersboolean.
Changes:
manualtopre-commitstage for non-provider projectsmypy_local.py(superseded by folder-level checks)ci-image-checks.ymlintoci-amd-arm.ymldirectlymypy-checks/run-mypyinputs fromci-image-checks.ymlmypy_checkslist andrun_mypywith singlerun_mypy_providersboolean in selective checksskip_prek_hooks(skips when relevant files unchanged)contributing-docs/08_static_code_checks.rsttype: ignore[no-redef]ontomllibcompat imports (12 files)type: ignore[attr-defined]for Linux-onlyos.posix_fadviseWas generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Claude Opus 4.6) following the guidelines