Add deadline alert coverage to DAG endpoint tests#64815
Open
shivaam wants to merge 2 commits intoapache:mainfrom
Open
Add deadline alert coverage to DAG endpoint tests#64815shivaam wants to merge 2 commits intoapache:mainfrom
shivaam wants to merge 2 commits intoapache:mainfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /dags,GET /dags/{id},GET /dags/{id}/details,PATCH /dags/{id},PATCH /dags, andDELETE /dags/{id}clear_db_deadlineandclear_db_deadline_alertto test cleanup to prevent FK constraint issuesDetails
The public DAG endpoint tests (
test_dags.py) never created DAGs with deadlines, so there was zero coverage for how the API behaves whenDagModel._deadlinehas data andSerializedDagModel.deadline_alertshas FK-linked records.7 new test methods across 6 test classes. No existing tests modified.
Note:
DAGResponseandDAGDetailsResponsedo not yet include deadline fields (that work is tracked separately in #50574), so these tests verify the endpoints return correct responses without errors — not the deadline data itself. Once response fields are added, these tests can be extended with deadline-specific assertions.closes: #50992
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.6) following the guidelines