Skip to content

[AIRFLOW-XXX] Add How-To-Guide to GoogleCloudStorageToSFTPOperator#6488

Merged
potiuk merged 3 commits into
apache:masterfrom
PolideaInternal:add-howto-gcs-to-sftp
Nov 4, 2019
Merged

[AIRFLOW-XXX] Add How-To-Guide to GoogleCloudStorageToSFTPOperator#6488
potiuk merged 3 commits into
apache:masterfrom
PolideaInternal:add-howto-gcs-to-sftp

Conversation

@TobKed
Copy link
Copy Markdown
Contributor

@TobKed TobKed commented Nov 1, 2019

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

@TobKed TobKed force-pushed the add-howto-gcs-to-sftp branch from 2fe27aa to d76e7bf Compare November 1, 2019 23:59
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 2, 2019

Codecov Report

Merging #6488 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6488      +/-   ##
==========================================
- Coverage   83.96%   83.72%   -0.25%     
==========================================
  Files         635      635              
  Lines       36661    36674      +13     
==========================================
- Hits        30783    30705      -78     
- Misses       5878     5969      +91
Impacted Files Coverage Δ
airflow/operators/gcs_to_sftp.py 100% <ø> (ø) ⬆️
airflow/example_dags/example_gcs_to_sftp.py 100% <ø> (ø) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/kube_client.py 33.33% <0%> (-41.67%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 70.14% <0%> (-28.36%) ⬇️
airflow/hooks/postgres_hook.py 94.28% <0%> (-2.21%) ⬇️
airflow/utils/dag_processing.py 58.48% <0%> (+0.16%) ⬆️
airflow/hooks/dbapi_hook.py 91.52% <0%> (+0.84%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4a83bc...112b5d9. Read the comment docs.

@TobKed
Copy link
Copy Markdown
Contributor Author

TobKed commented Nov 2, 2019

Hey @mschickensoup, could you take a look in spare time please? CC @mik-laj

Copy link
Copy Markdown
Member

@turbaszek turbaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just two suggestions ✅

Comment thread docs/howto/operator/gcp/gcs_to_sftp.rst Outdated
Comment thread docs/howto/operator/gcp/gcs_to_sftp.rst Outdated
@TobKed
Copy link
Copy Markdown
Contributor Author

TobKed commented Nov 4, 2019

@mik-laj @nuclearpinguin I've applied your suggestions

@potiuk potiuk merged commit ba40be7 into apache:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants