[AIRFLOW-5829] Get rid of the checklicence image.#6495
Merged
potiuk merged 1 commit intoNov 6, 2019
Conversation
5 tasks
a3e0b43 to
0a4e6b7
Compare
mik-laj
reviewed
Nov 4, 2019
9c794ab to
3e4348b
Compare
3e4348b to
24562ff
Compare
This was referenced Nov 4, 2019
c65b53b to
c9a627a
Compare
c9a627a to
2f87e82
Compare
Member
Author
|
This one is green. Looking forward to merging this one as well (getting rid of checklicence image). |
Member
Author
|
And we have now one static check job in Travis run with single image - less overhead for starting VMs on Travis. See https://travis-ci.org/apache/airflow/builds/607930228 |
Member
Author
|
Note that this build lasts longer but when we merge to master the image will be pushed to Dockerhub (I will speed it up with my build server in GCP) and they will be much faster (10 minutes each). |
mik-laj
approved these changes
Nov 6, 2019
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze.
2f87e82 to
6bd5e9b
Compare
potiuk
added a commit
that referenced
this pull request
Nov 6, 2019
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
potiuk
added a commit
that referenced
this pull request
Nov 12, 2019
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
eladkal
pushed a commit
to eladkal/airflow
that referenced
this pull request
Dec 2, 2019
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
kaxil
pushed a commit
that referenced
this pull request
Dec 12, 2019
This change is a further step of simplifying the set of scripts used by CI. The separate checklicence image was implemented as an optimisation of the licence check time. The image to download was small and could be downloaded slightly faster in CI. However that made all the management script more complex and lead to having separate jobs for check licence and static checks. That lead to actually longer time of Travis jobs - because new machine had to be spun-off for checklicence check only. With this change, the CI image is the only one left and it is slightly bigger (with RAT tool added) but the same image is used for all the tests - unit tests, static checks and checklicence checks. This also makes it easier to manage the images and decreases update overhead on the developers using Breeze. (cherry picked from commit d4ff529)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is a further step of simplifying the set of scripts
used by CI. The separate checklicence image was implemented as an
optimisation of the licence check time. The image to download was
small and could be downloaded slightly faster in CI. However that
made all the management script more complex and lead to having
separate jobs for check licence and static checks. That lead to
actually longer time of Travis jobs - because new machine had to
be spun-off for checklicence check only.
With this change, the CI image is the only one left and it is slightly
bigger (with RAT tool added) but the same image is used for all the
tests - unit tests, static checks and checklicence checks.
This also makes it easier to manage the images and decreases update
overhead on the developers using Breeze.
Make sure you have checked all steps below.
Jira
Description
Tests
Commits
Documentation