Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
|
This PR has unrelated changes. |
|
Converted to Draft. |
There was a problem hiding this comment.
Pull request overview
This PR primarily fixes a malformed link in INTHEWILD.md, but it also updates the repository-wide pre-commit Python interpreter setting.
Changes:
- Fix malformed Bloomberg GitHub profile link in
INTHEWILD.md. - Change root
.pre-commit-config.yamldefault_language_version.pythonfrompython3topython310.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
INTHEWILD.md |
Corrects a broken GitHub profile URL for the Bloomberg entry. |
.pre-commit-config.yaml |
Modifies the default Python interpreter used by pre-commit hooks. |
| minimum_prek_version: '0.3.4' | ||
| default_language_version: | ||
| python: python3 | ||
| python: python310 |
There was a problem hiding this comment.
default_language_version.python is set to python310, which is not a standard interpreter executable name on many systems (pre-commit will try to run python310). Elsewhere in this repo the convention is python3 (e.g. airflow-core/.pre-commit-config.yaml:21 and even this file sets language_version: python3 for the bandit hook). Consider reverting to python3 (or, if pinning is required, use an executable name that actually exists across platforms, and align all pre-commit configs consistently).
| python: python310 | |
| python: python3 |
| default_stages: [pre-commit, pre-push] | ||
| minimum_prek_version: '0.3.4' | ||
| default_language_version: | ||
| python: python3 | ||
| python: python310 | ||
| node: 22.19.0 |
There was a problem hiding this comment.
The PR is titled/described as a documentation typo fix, but this hunk changes the repository’s pre-commit Python interpreter selection. If this is intentional, the PR title/description should reflect a tooling change; otherwise this looks like an accidental edit and should be reverted to keep the PR scoped to docs.
Was generative AI tooling used to co-author this PR?
Updated Documentation typos
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.