Fix DagProcessorJob crash with ValueError: write to closed file on or…#65002
Open
Saddala wants to merge 2 commits intoapache:mainfrom
Open
Fix DagProcessorJob crash with ValueError: write to closed file on or…#65002Saddala wants to merge 2 commits intoapache:mainfrom
Saddala wants to merge 2 commits intoapache:mainfrom
Conversation
…phan kill After SIGKILL, stale socket registrations on the shared selector cause the next select() callback to write to an already-closed log handle. Add _deregister_processor_sockets() to clean up sockets before closing the handle, and guard target.log() in the supervisor against ValueError. Closes: apache#64959
Saddala
requested review from
amoghrajesh,
ashb,
ephraimbuddy,
jedcunningham and
kaxil
as code owners
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
- test_deregister_processor_sockets_suppresses_already_unregistered: KeyError from selector.unregister() is suppressed - test_deregister_processor_sockets_suppresses_close_error: OSError from sock.close() is suppressed - test_terminate_orphan_processes_deregisters_sockets: sockets are unregistered and closed before logger_filehandle.close() - test_kill_timed_out_processors_deregisters_sockets: same coverage for the timed-out processors cleanup path - test_process_log_messages_tolerates_closed_log_handle: generator returns cleanly on ValueError instead of propagating it Generated-by: Claude Sonnet 4.6 following the guidelines https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After SIGKILL, stale socket registrations on the shared selector cause the next
select()callback to write to an already-closedBytesLoggerhandle, raisingValueError: write to closed fileand crashing the entireDagProcessorJob._deregister_processor_sockets()to unregister and close all sockets for a killed processor beforelogger_filehandle.close()is called. Applied in bothterminate_orphan_processesand_kill_timed_out_processors.target.log()inprocess_log_messages_from_subprocesswith aValueErrorcatch that discards remaining buffered output cleanly.closes: #64959