Fix clipped dropdowns in connection form#65017
Closed
DaveT1991 wants to merge 2 commits intoapache:mainfrom
Closed
Fix clipped dropdowns in connection form#65017DaveT1991 wants to merge 2 commits intoapache:mainfrom
DaveT1991 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
|
Cool! Can you provide a screenshot of before and after? |
Contributor
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Fixes #65007
Connection form dropdowns can be clipped inside the dialog and accordion layout, which makes some values inaccessible when a custom connection field exposes a long enum list.
This change renders the affected
chakra-react-selectmenus in a portal attached todocument.body, usesmenuPosition="fixed", and applies a modal-safe z-index so the dropdown list can escape the accordion/container clipping and remain fully visible.Changes:
Validation:
pnpm exec eslint src/utils/advancedSelectStyles.ts src/components/FlexibleForm/FieldDropdown.tsx src/components/FlexibleForm/FieldMultiSelect.tsx src/components/TeamSelector.tsx src/pages/Connections/ConnectionForm.tsx src/components/FlexibleForm/FieldDropdown.test.tsxpnpm exec vitest run src/components/FlexibleForm/FieldDropdown.test.tsx