Skip to content

Fix clipped dropdowns in connection form#65017

Closed
DaveT1991 wants to merge 2 commits intoapache:mainfrom
DaveT1991:fix/connection-form-dropdown-overflow
Closed

Fix clipped dropdowns in connection form#65017
DaveT1991 wants to merge 2 commits intoapache:mainfrom
DaveT1991:fix/connection-form-dropdown-overflow

Conversation

@DaveT1991
Copy link
Copy Markdown
Contributor

Fixes #65007

Connection form dropdowns can be clipped inside the dialog and accordion layout, which makes some values inaccessible when a custom connection field exposes a long enum list.

This change renders the affected chakra-react-select menus in a portal attached to document.body, uses menuPosition="fixed", and applies a modal-safe z-index so the dropdown list can escape the accordion/container clipping and remain fully visible.

Changes:

  • add shared portalled select menu styling for connection-form selects
  • apply the shared portal configuration to flexible-form single-select fields
  • apply the shared portal configuration to flexible-form multi-select fields
  • apply the same portal configuration to the connection type and team selectors
  • add a regression test asserting the flexible-form dropdown uses the portalled menu configuration

Validation:

  • pnpm exec eslint src/utils/advancedSelectStyles.ts src/components/FlexibleForm/FieldDropdown.tsx src/components/FlexibleForm/FieldMultiSelect.tsx src/components/TeamSelector.tsx src/pages/Connections/ConnectionForm.tsx src/components/FlexibleForm/FieldDropdown.test.tsx
  • pnpm exec vitest run src/components/FlexibleForm/FieldDropdown.test.tsx

@boring-cyborg boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Apr 10, 2026
@bbovenzi bbovenzi added this to the Airflow 3.2.1 milestone Apr 10, 2026
@bbovenzi bbovenzi added the backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch label Apr 10, 2026
@bbovenzi
Copy link
Copy Markdown
Contributor

Cool! Can you provide a screenshot of before and after?

@DaveT1991
Copy link
Copy Markdown
Contributor Author

Cool! Can you provide a screenshot of before and after?

Before:
image

After:
image

@kaxil kaxil requested a review from Copilot April 10, 2026 19:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@kaxil
Copy link
Copy Markdown
Member

kaxil commented Apr 11, 2026

Cool! Can you provide a screenshot of before and after?

Before: image

After: image

This isn't the screenshot of Airflow UI!

@kaxil kaxil closed this Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-2-test Mark PR with this label to backport to v3-2-test branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dropdown list is not fully visible in connection form

4 participants