Skip to content

Comments

[AIRFLOW-5852] Make tests.www pylint compatible#6504

Merged
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:pylint-tests-www
Nov 5, 2019
Merged

[AIRFLOW-5852] Make tests.www pylint compatible#6504
potiuk merged 1 commit intoapache:masterfrom
PolideaInternal:pylint-tests-www

Conversation

@turbaszek
Copy link
Member

Make sure you have checked all steps below.

Jira

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

# for classes with dynamically set attributes). This supports the use of
# qualified names.
ignored-classes=optparse.Values,thread._local,_thread._local
ignored-classes=optparse.Values,thread._local,_thread._local,sqlalchemy.orm.scoping.scoped_session
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mik-laj @potiuk @ashb what do you think about ignoring this class? Otherwise we will have to disable no-member.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for ignoring this class.

@codecov-io
Copy link

codecov-io commented Nov 5, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5096fa3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6504   +/-   ##
=========================================
  Coverage          ?   83.64%           
=========================================
  Files             ?      635           
  Lines             ?    36679           
  Branches          ?        0           
=========================================
  Hits              ?    30681           
  Misses            ?     5998           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5096fa3...136b169. Read the comment docs.

@potiuk
Copy link
Member

potiuk commented Nov 5, 2019

+1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants